Bug 73907

Summary: [qt][wk2] Tests of QQuickWebView assert in debug builds when destroying QQuickWebViewPrivate
Product: WebKit Reporter: Michael Brüning <michael.bruning>
Component: WebKit2Assignee: Michael Brüning <michael.bruning>
Status: RESOLVED FIXED    
Severity: Normal CC: kenneth, webkit.review.bot, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch to fix assertion.
none
Updated patch using disconnect instead of blockSignals
kenneth: review+
Patch with fixed ChangeLog and commit message. none

Michael Brüning
Reported 2011-12-06 04:28:53 PST
The assert happens because the destructor of QQuickWebViewPrivate destroys the interaction engine, which in turn emits a signal that is handled by QQuickWebViewPrivate.
Attachments
Patch to fix assertion. (3.12 KB, patch)
2011-12-06 04:45 PST, Michael Brüning 		no flags
DetailsFormatted DiffDiff
Updated patch using disconnect instead of blockSignals (3.11 KB, patch)
2011-12-06 06:02 PST, Michael Brüning 		kenneth: review+
DetailsFormatted DiffDiff
Patch with fixed ChangeLog and commit message. (3.12 KB, patch)
2011-12-06 06:43 PST, Michael Brüning 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Michael Brüning
Comment 1 2011-12-06 04:45:07 PST
Created attachment 118028 [details] Patch to fix assertion.
Kenneth Rohde Christiansen
Comment 2 2011-12-06 04:47:58 PST
Comment on attachment 118028 [details] Patch to fix assertion. View in context: https://bugs.webkit.org/attachment.cgi?id=118028&action=review > Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:79 > +{ > + if (interactionEngine) > + interactionEngine->blockSignals(true); > +} why not disconnect all signals?
Michael Brüning
Comment 3 2011-12-06 06:02:24 PST
Created attachment 118035 [details] Updated patch using disconnect instead of blockSignals Update according to Kenneth's comment.
Michael Brüning
Comment 4 2011-12-06 06:04:23 PST
Comment on attachment 118035 [details] Updated patch using disconnect instead of blockSignals Updating flags
Kenneth Rohde Christiansen
Comment 5 2011-12-06 06:34:38 PST
Comment on attachment 118035 [details] Updated patch using disconnect instead of blockSignals View in context: https://bugs.webkit.org/attachment.cgi?id=118035&action=review > Source/WebKit2/ChangeLog:8 > + * UIProcess/API/qt/qquickwebview.cpp: Block signals from QtViewportInteractionEngine in diconnect
Michael Brüning
Comment 6 2011-12-06 06:43:19 PST
Created attachment 118041 [details] Patch with fixed ChangeLog and commit message. Fixed the ChangeLog and commit message.
WebKit Review Bot
Comment 7 2011-12-06 08:35:57 PST
Comment on attachment 118041 [details] Patch with fixed ChangeLog and commit message. Clearing flags on attachment: 118041 Committed r102142: <http://trac.webkit.org/changeset/102142>
WebKit Review Bot
Comment 8 2011-12-06 08:36:01 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.