Bug 73879

Summary: Revert WebCore track settings changes made in r101977
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit-bug-importer, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 43668    
Attachments:
Description Flags
Proposed patch none

Eric Carlson
Reported 2011-12-05 17:15:13 PST
From https://bugs.webkit.org/show_bug.cgi?id=73721: > Source/WebCore/page/Settings.cpp:854 > +#if ENABLE(VIDEO_TRACK) > +void Settings::setShouldDisplaySubtitles(bool flag) > +{ > + m_shouldDisplaySubtitles = flag; > +} > + > +void Settings::setShouldDisplayCaptions(bool flag) > +{ > + m_shouldDisplayCaptions = flag; > +} > + > +void Settings::setShouldDisplayTextDescriptions(bool flag) > +{ > + m_shouldDisplayTextDescriptions = flag; > +} > +#endif Why this change? You moved these into the cpp file, but they are the same as what was in the .h file?
Attachments
Proposed patch (2.57 KB, patch)
2011-12-05 17:28 PST, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2011-12-05 17:15:53 PST
<rdar://problem/10531518>
Eric Carlson
Comment 2 2011-12-05 17:28:29 PST
Created attachment 117960 [details] Proposed patch
WebKit Review Bot
Comment 3 2011-12-06 11:01:39 PST
Comment on attachment 117960 [details] Proposed patch Clearing flags on attachment: 117960 Committed r102154: <http://trac.webkit.org/changeset/102154>
WebKit Review Bot
Comment 4 2011-12-06 11:01:43 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.