Bug 73672

Summary: [Chromium] Add Android keycodes and build Linux clipboard/filesystem files.
Product: WebKit Reporter: Peter Beverloo <peter>
Component: PlatformAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, cc-bugs, jamesr, jrg, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 73849    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch
abarth: review+, webkit.review.bot: commit-queue-
Patch for landing none

Peter Beverloo
Reported 2011-12-02 10:10:56 PST
Add the KeyCodeConversionAndroid.cpp file, which is a partial re-land of an older file from the Android port: http://trac.webkit.org/browser/trunk/WebCore/platform/android/KeyEventAndroid.cpp?rev=56704 Add IconChromiumAndroid.cpp which nullifies the rendering of icons in file upload boxes, which is not something we want to support now. Also include ClipboardChromiumLinux.cpp and FileSystemChromiumLinux.cpp as their functionality can be re-used for Android.
Attachments
Patch (9.93 KB, patch)
2011-12-02 10:14 PST, Peter Beverloo 		abarth: review+
webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Patch for landing (11.27 KB, patch)
2011-12-05 02:24 PST, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2011-12-02 10:14:00 PST
Created attachment 117647 [details] Patch Note for the reviewers: An alternative solution to adding a new IconChromiumAndroid.cpp file would be to #ifdef out the implementation in IconChromium.cpp, but overall I think this is cleaner. http://codesearch.google.com/#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/platform/graphics/chromium/IconChromium.cpp&exact_package=chromium&q=IconChromium.cpp&type=cs&l=48
Peter Beverloo
Comment 2 2011-12-02 10:50:43 PST
Thanks!
WebKit Review Bot
Comment 3 2011-12-02 14:49:20 PST
Comment on attachment 117647 [details] Patch Rejecting attachment 117647 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 2 Last 500 characters of output: webkit-commit-queue/Source/WebKit/chromium/webkit --revision 112463 --non-interactive --force --accept theirs-conflict --ignore-externals' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' 49>At revision 112463. ________ running '/usr/bin/python tools/clang/scripts/update.py --mac-only' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' ________ running '/usr/bin/python gyp_webkit' in '/mnt/git/webkit-commit-queue/Source/WebKit/chromium' Updating webkit projects from gyp files... Full output: http://queues.webkit.org/results/10729173
Peter Beverloo
Comment 4 2011-12-05 02:24:28 PST
Created attachment 117858 [details] Patch for landing I have no idea where the ChangeLog disappeared to, anyway, hereby the patch for landing.
WebKit Review Bot
Comment 5 2011-12-05 11:10:42 PST
Comment on attachment 117858 [details] Patch for landing Clearing flags on attachment: 117858 Committed r102018: <http://trac.webkit.org/changeset/102018>
WebKit Review Bot
Comment 6 2011-12-05 11:10:47 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.