Bug 73308

Summary: [WebSocket] Add OVERRIDE to WebSocket related sources in WebCore
Product: WebKit Reporter: Takashi Toyoshima <toyoshim>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, tkent, webkit.review.bot, yutak
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 73290    
Bug Blocks:    
Attachments:
Description Flags
Patch
tkent: review-
Patch again
none
Patch none

Takashi Toyoshima
Reported 2011-11-29 04:41:00 PST
We must add OVERRIDE to inherited methods definition for safe inheritance.
Attachments
Patch (10.73 KB, patch)
2011-11-29 06:14 PST, Takashi Toyoshima 		tkent: review-
DetailsFormatted DiffDiff
Patch again (10.73 KB, patch)
2011-11-30 08:07 PST, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
Patch (10.67 KB, patch)
2011-11-30 09:10 PST, Takashi Toyoshima 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Takashi Toyoshima
Comment 1 2011-11-29 06:14:37 PST
Created attachment 116958 [details] Patch
Takashi Toyoshima
Comment 2 2011-11-29 06:44:26 PST
Oh, bots failed because this change depends on ongoing patch.
Kent Tamura
Comment 3 2011-11-29 18:04:50 PST
Comment on attachment 116958 [details] Patch > Oh, bots failed because this change depends on ongoing patch. So, this patch is not ready for review.
Takashi Toyoshima
Comment 4 2011-11-30 08:07:30 PST
Created attachment 117195 [details] Patch again
Takashi Toyoshima
Comment 5 2011-11-30 08:12:29 PST
Comment on attachment 117195 [details] Patch again Sorry, bots still fails applying this patch. I'll investigate it and upload another again.
Takashi Toyoshima
Comment 6 2011-11-30 09:10:58 PST
Created attachment 117203 [details] Patch
Kent Tamura
Comment 7 2011-11-30 14:11:53 PST
Comment on attachment 117203 [details] Patch ok
WebKit Review Bot
Comment 8 2011-11-30 19:45:11 PST
Comment on attachment 117203 [details] Patch Clearing flags on attachment: 117203 Committed r101594: <http://trac.webkit.org/changeset/101594>
WebKit Review Bot
Comment 9 2011-11-30 19:45:22 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.