Bug 73191

Summary:

JS_INLINE and WTF_INLINE should be visible from WebCore

Product:

WebKit

Reporter:

Hajime Morrita <morrita>

Component:

Platform

Assignee:

Hajime Morrita <morrita>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, kevino, mrowe, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

67852

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none
Patch for landing	none
Patch	none
Patch	none
Patch	none

Hajime Morrita

Reported 2011-11-27 23:33:02 PST

http://trac.webkit.org/changeset/101198 introduced JS_INLINE and WTF_INLINE but changing JavaScriptCore/config.h was not sufficient.

Attachments
Patch (10.90 KB, patch) 2011-11-28 02:49 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (23.43 KB, patch) 2011-11-29 01:14 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (23.99 KB, patch) 2011-11-29 01:29 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (24.14 KB, patch) 2011-11-29 02:18 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (40.75 KB, patch) 2011-11-30 02:01 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (40.83 KB, patch) 2011-11-30 23:12 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (42.00 KB, patch) 2011-12-01 04:00 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch for landing (42.09 KB, patch) 2011-12-01 20:35 PST, Hajime Morrita	no flags	Details Formatted Diff Diff
Patch (46.87 KB, patch) 2011-12-12 23:31 PST, Kevin Ollivier	no flags	Details Formatted Diff Diff
Patch (47.05 KB, patch) 2011-12-13 00:06 PST, Kevin Ollivier	no flags	Details Formatted Diff Diff
Patch (47.15 KB, patch) 2011-12-14 09:29 PST, Kevin Ollivier	no flags	Details Formatted Diff Diff
Show Obsolete (10) View All Add attachment proposed patch, testcase, etc.

Hajime Morrita

Comment 1 2011-11-28 02:49:05 PST

Created attachment 116720 [details] Patch

Mark Rowe (bdash)

Comment 2 2011-11-28 03:03:23 PST

Comment on attachment 116720 [details] Patch It seems like a layering violation for WTF to be providing JSC-specific macros.

Kevin Ollivier

Comment 3 2011-11-28 08:46:15 PST

(In reply to comment #2) > (From update of attachment 116720 [details]) > It seems like a layering violation for WTF to be providing JSC-specific macros. I agree, though like Hajime I'd like to see us get away from defining the various WTF, JS and WebCore export macros in every library that includes headers from them. Perhaps the best idea is to have each library have its own WTFMacros.h, JSMacros.h, etc. that includes wtf/ExportMacros.h and then defines the library-specific ones like JS_EXPORTDATA / CLASS / _PRIVATE. One thing, though, is that this consolidation of macros into a single header might be easier to do once all ports are using the export macros, so I'm not sure if we should tackle it now or just add the macros to the various config.h files (as was done for the previous macros like JS_EXPORTDATA, etc.) and then have the macro consolidation as a separate bug that we make a blocker of the master bug. Thoughts?

Hajime Morrita

Comment 4 2011-11-29 01:14:01 PST

Created attachment 116917 [details] Patch

Hajime Morrita

Comment 5 2011-11-29 01:18:09 PST

Kevin, Mark, thanks for your feedback! (In reply to comment #2) > (From update of attachment 116720 [details]) > It seems like a layering violation for WTF to be providing JSC-specific macros. This makes sense. So I extracted JSC specific part to JSExportMacros.h and WebKit prefixed ones to PlatformExportMacros.h. Actually this looks unexpectedly better than original one. I originally thought same as Kevin, but the this patch looks natural for me. Note that the style error is false positive. inclusion order matters there.

Hajime Morrita

Comment 6 2011-11-29 01:29:23 PST

Created attachment 116919 [details] Patch

WebKit Review Bot

Comment 7 2011-11-29 01:31:50 PST

Attachment 116919 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/config.h:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/PlatformExportMacros.h:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/config.h:37: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/JSExportMacros.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 4 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 8 2011-11-29 01:42:08 PST

Comment on attachment 116919 [details] Patch Attachment 116919 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10683111

WebKit Review Bot

Comment 9 2011-11-29 01:58:21 PST

Comment on attachment 116919 [details] Patch Attachment 116919 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10682291

Hajime Morrita

Comment 10 2011-11-29 02:18:53 PST

Created attachment 116929 [details] Patch

WebKit Review Bot

Comment 11 2011-11-29 02:22:00 PST

Attachment 116929 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebCore/platform/PlatformExportMacros.h:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/config.h:37: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/runtime/JSExportMacros.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 3 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 12 2011-11-29 02:33:46 PST

Comment on attachment 116929 [details] Patch Attachment 116929 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10685058

WebKit Review Bot

Comment 13 2011-11-29 02:42:47 PST

Comment on attachment 116929 [details] Patch Attachment 116929 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10679573

Hajime Morrita

Comment 14 2011-11-30 02:01:41 PST

Created attachment 117147 [details] Patch

WebKit Review Bot

Comment 15 2011-11-30 02:06:48 PST

Attachment 117147 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebKit2/config.h:37: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptGlue/config.h:6: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptGlue/config.h:7: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/PlatformExportMacros.h:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:74: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:75: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:76: Alphabetical sorting problem. [build/include_order] [4] Tools/DumpRenderTree/chromium/config.h:46: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:55: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:59: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:60: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:61: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/JSExportMacros.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 16 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 16 2011-11-30 02:22:13 PST

Comment on attachment 117147 [details] Patch Attachment 117147 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10687140

Hajime Morrita

Comment 17 2011-11-30 23:12:23 PST

Created attachment 117349 [details] Patch

WebKit Review Bot

Comment 18 2011-11-30 23:15:53 PST

Attachment 117349 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebKit2/config.h:37: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptGlue/config.h:6: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptGlue/config.h:7: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/PlatformExportMacros.h:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:74: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:75: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:76: Alphabetical sorting problem. [build/include_order] [4] Tools/DumpRenderTree/chromium/config.h:46: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:55: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:59: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:60: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:61: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/JSExportMacros.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 16 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 19 2011-11-30 23:32:08 PST

Comment on attachment 117349 [details] Patch Attachment 117349 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10704510

Hajime Morrita

Comment 20 2011-12-01 04:00:44 PST

Created attachment 117393 [details] Patch

WebKit Review Bot

Comment 21 2011-12-01 04:03:58 PST

Attachment 117393 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebKit2/config.h:37: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptGlue/config.h:6: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptGlue/config.h:7: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/PlatformExportMacros.h:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:74: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:75: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:76: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/qt/ChangeLog:8: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Tools/DumpRenderTree/chromium/config.h:46: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:55: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:59: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:60: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:61: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/JSExportMacros.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 17 in 32 files If any of these errors are false positives, please file a bug against check-webkit-style.

Hajime Morrita

Comment 22 2011-12-01 17:59:38 PST

Mark, Kevin, could you take a look? I think the patch is finally ready to review: The style error is false positive, bots have become green. This patch is a refactoring essentially. What I did is extract duplicate macro definitions in various config.h files to shared ExportMacros.h/JSExportMacros.h/PlatformExportMacros.h header files.

WebKit Review Bot

Comment 23 2011-12-01 18:38:19 PST

Comment on attachment 117393 [details] Patch Rejecting attachment 117393 [details] from commit-queue. Failed to run "['/mnt/git/webkit-commit-queue/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '-..." exit_code: 1 ERROR: /mnt/git/webkit-commit-queue/Source/WebCore/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). Full output: http://queues.webkit.org/results/10725140

Hajime Morrita

Comment 24 2011-12-01 20:35:39 PST

Created attachment 117554 [details] Patch for landing

WebKit Review Bot

Comment 25 2011-12-01 23:33:56 PST

Comment on attachment 117554 [details] Patch for landing Clearing flags on attachment: 117554 Committed r101751: <http://trac.webkit.org/changeset/101751>

WebKit Review Bot

Comment 26 2011-12-01 23:34:02 PST

All reviewed patches have been landed. Closing bug.

Hajime Morrita

Comment 27 2011-12-02 03:41:51 PST

Reverted r101751 for reason: breaks Windows build Committed r101778: <http://trac.webkit.org/changeset/101778>

Kevin Ollivier

Comment 28 2011-12-12 23:31:05 PST

Created attachment 118962 [details] Patch

Kevin Ollivier

Comment 29 2011-12-12 23:31:57 PST

This is the same patch as Hajime's except with the added Windows build fixes. I'll land if it now passes all the EWS bots.

WebKit Review Bot

Comment 30 2011-12-12 23:32:57 PST

Attachment 118962 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebKit2/config.h:37: Alphabetical sorting problem. [build/include_order] [4] Tools/DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Source/JavaScriptGlue/config.h:6: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptGlue/config.h:7: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/PlatformExportMacros.h:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:74: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:75: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:76: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/qt/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Tools/DumpRenderTree/chromium/config.h:46: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:55: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:59: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:60: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:61: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/JSExportMacros.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 18 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 31 2011-12-12 23:41:45 PST

Comment on attachment 118962 [details] Patch Attachment 118962 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10846250

Gyuyoung Kim

Comment 32 2011-12-12 23:48:29 PST

Comment on attachment 118962 [details] Patch Attachment 118962 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10848274

WebKit Review Bot

Comment 33 2011-12-12 23:51:02 PST

Comment on attachment 118962 [details] Patch Attachment 118962 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10846251

Kevin Ollivier

Comment 34 2011-12-13 00:06:40 PST

Created attachment 118965 [details] Patch

WebKit Review Bot

Comment 35 2011-12-13 00:09:48 PST

Attachment 118965 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebKit2/config.h:37: Alphabetical sorting problem. [build/include_order] [4] Tools/DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Source/JavaScriptGlue/config.h:6: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptGlue/config.h:7: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/PlatformExportMacros.h:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:74: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:75: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:76: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/qt/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Tools/DumpRenderTree/chromium/config.h:46: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:55: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:59: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:60: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:61: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/JSExportMacros.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 18 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.

Kevin Ollivier

Comment 36 2011-12-14 09:29:50 PST

Created attachment 119234 [details] Patch

WebKit Review Bot

Comment 37 2011-12-14 09:33:23 PST

Attachment 119234 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebKit2/config.h:37: Alphabetical sorting problem. [build/include_order] [4] Tools/DumpRenderTree/ForwardingHeaders/runtime/JSExportMacros.h:1: Could not find a newline character at the end of the file. [whitespace/ending_newline] [5] Source/JavaScriptGlue/config.h:6: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptGlue/config.h:7: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/platform/PlatformExportMacros.h:33: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:74: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:75: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/mac/WebKitPrefix.h:76: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/qt/ChangeLog:10: Need whitespace between colon and description [changelog/filechangedescriptionwhitespace] [5] Tools/DumpRenderTree/chromium/config.h:46: Alphabetical sorting problem. [build/include_order] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:55: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:56: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:57: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:58: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:59: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:60: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/wtf/text/StringStatics.cpp:61: DEFINE_GLOBAL is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/JavaScriptCore/runtime/JSExportMacros.h:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 18 in 36 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 38 2011-12-14 16:51:59 PST

Comment on attachment 119234 [details] Patch Clearing flags on attachment: 119234 Committed r102849: <http://trac.webkit.org/changeset/102849>

WebKit Review Bot

Comment 39 2011-12-14 16:52:06 PST

All reviewed patches have been landed. Closing bug.

Mark Rowe (bdash)

Comment 40 2011-12-14 18:43:30 PST

Please make sure that you don’t set the svn:executable property on files unnecessarily. It can cause build failures in some environments.

Kevin Ollivier

Comment 41 2011-12-14 20:29:27 PST

(In reply to comment #40) > Please make sure that you don’t set the svn:executable property on files unnecessarily. It can cause build failures in some environments. Sorry, it was not intentional, but I will be sure to double-check this in the future. Thanks for fixing it!

Note You need to log in before you can comment on or make changes to this bug.