Bug 72960

Summary: Allow JSC heuristics to be set on the command-line
Product: WebKit Reporter: Andy Wingo <wingo>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: UNCONFIRMED    
Severity: Normal CC: barraclough, fpizlo, mrowe
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 74498    
Bug Blocks: 72962, 74510    
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Patch none

Andy Wingo
Reported 2011-11-22 08:16:47 PST
Allow JSC heuristics to be set on the command-line
Attachments
Patch (14.73 KB, patch)
2011-11-22 08:23 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Patch (14.39 KB, patch)
2011-11-22 08:24 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Patch (14.41 KB, patch)
2011-11-25 07:24 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Patch (16.22 KB, patch)
2011-11-29 09:51 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Patch (17.93 KB, patch)
2011-12-14 05:13 PST, Andy Wingo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Andy Wingo
Comment 1 2011-11-22 08:23:26 PST
Created attachment 116230 [details] Patch
Andy Wingo
Comment 2 2011-11-22 08:24:55 PST
Created attachment 116231 [details] Patch
Andy Wingo
Comment 3 2011-11-25 07:24:10 PST
Created attachment 116616 [details] Patch
Andy Wingo
Comment 4 2011-11-25 07:25:31 PST
Previous patch defined BadValue as one of the enumerated values, but that is #defined by xlib. Change to InvalidValue. Terrible.
Andy Wingo
Comment 5 2011-11-29 09:51:26 PST
Created attachment 116988 [details] Patch
Andy Wingo
Comment 6 2011-11-29 09:57:26 PST
New patch folds in support for boolean flags without values, e.g. --dump-bytecode / --no-dump-bytecode, and refactors support for parsing values from environment.
Gavin Barraclough
Comment 7 2011-11-29 12:00:25 PST
This seems useful for development purposes, but we ship a copy of jsc with the system, and I doubt we want to add this interface in customer releases. Clearly we don't want to restrict this to debug builds, since a key use of these switches may be performance testing, but I think there may be a define that will distinguish between release & production builds. Let me look into this.
Gavin Barraclough
Comment 8 2011-11-29 12:05:27 PST
Actually, better still, I'll cc bdash! Mark, is there a #define that will distinguish development release build from production builds?
Mark Rowe (bdash)
Comment 9 2011-11-29 12:55:01 PST
There’s not. I’m a little skeptical of the value of this patch though. These heuristics are infrequently changed. In the rare even that someone wants to experiment with tuning them it’s straightforward to tweak the constants in the source.
Andy Wingo
Comment 10 2011-11-30 02:08:10 PST
(In reply to comment #9) > I’m a little skeptical of the value of this patch though. These heuristics are infrequently changed. In the rare even that someone wants to experiment with tuning them it’s straightforward to tweak the constants in the source. This is a good argument with the current set of heuristics. But with future boolean flags, I think that command-line integration is a lot more convincing. Two examples: the JVM flags: http://www.oracle.com/technetwork/java/javase/tech/vmoptions-jsp-140102.html and the V8 flags: http://paste.lisp.org/display/126181 If your main concern is the specific interface offered by jsc, another option would be to create another binary. WDYT? I think it's useful to have these options in JSC proper, but there is definitely room to disagree.
Andy Wingo
Comment 11 2011-12-14 05:13:18 PST
Created attachment 119206 [details] Patch
Anders Carlsson
Comment 12 2014-02-05 10:51:25 PST
Comment on attachment 119206 [details] Patch Clearing review flag on patches from before 2014. If this patch is still relevant, please reset the r? flag.
Note You need to log in before you can comment on or make changes to this bug.