Bug 72853

Summary: Needs WTF_INLINE and JS_INLINE
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: Web Template FrameworkAssignee: Hajime Morrita <morrita>
Status: RESOLVED FIXED    
Severity: Normal CC: rakuco, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67852    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Hajime Morrita
Reported 2011-11-20 21:52:41 PST
We have WTF_EXPORT_PRIVATE and JS_EXPORT_PRIVATE for give "default" visibility. But when you put the default visibility to the class, its all method also become visible even if it is inline function, which makes Mac build sad because it doesn't allow inline visible function. We need WTF_INLINE and JS_INLINE to mark such inline function as "hidden". The patch will come shortly.
Attachments
Patch (1.88 KB, patch)
2011-11-20 23:54 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (2.56 KB, patch)
2011-11-20 23:54 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Patch (2.53 KB, patch)
2011-11-22 00:08 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2011-11-20 23:54:22 PST
Created attachment 116036 [details] Patch
Hajime Morrita
Comment 2 2011-11-20 23:54:50 PST
Created attachment 116037 [details] Patch
WebKit Review Bot
Comment 3 2011-11-20 23:56:12 PST
Attachment 116036 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/wtf/text/WTFString.h:114: The parameter type should use PassRefPtr instead of RefPtr. [readability/pass_ptr] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Kevin Ollivier
Comment 4 2011-11-21 09:39:49 PST
Comment on attachment 116037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=116037&action=review > Source/JavaScriptCore/wtf/ExportMacros.h:38 > +#define WTF_HIDDEN __attribute__((visibility("hidden"))) This is using the gcc syntax for hidden symbols inside of the !COMPILER(GCC) block. In MSVC, hidden is the default visibility, so we should probably just define WTF_HIDDEN as an empty string here. Otherwise, looks fine, so I'll r+ once this is fixed.
Hajime Morrita
Comment 5 2011-11-22 00:08:55 PST
Created attachment 116185 [details] Patch
Hajime Morrita
Comment 6 2011-11-22 00:09:43 PST
(In reply to comment #4) > This is using the gcc syntax for hidden symbols inside of the !COMPILER(GCC) block. In MSVC, hidden is the default visibility, so we should probably just define WTF_HIDDEN as an empty string here. > > Otherwise, looks fine, so I'll r+ once this is fixed. Hi Kevin, thanks for reviewing! I updated the patch which addresses the point.
WebKit Review Bot
Comment 7 2011-11-26 17:26:35 PST
Comment on attachment 116185 [details] Patch Clearing flags on attachment: 116185 Committed r101198: <http://trac.webkit.org/changeset/101198>
WebKit Review Bot
Comment 8 2011-11-26 17:26:40 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.