Bug 72582

Summary: WTF_EXPORT should be clang aware.
Product: WebKit Reporter: Hajime Morrita <morrita>
Component: Web Template FrameworkAssignee: Hajime Morrita <morrita>
Status: RESOLVED INVALID    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 67852    
Attachments:
Description Flags
Patch none

Hajime Morrita
Reported 2011-11-17 00:19:51 PST
Curretly WTF_EXPORT doesn't care about Clang compiler. Because Clang understands the same "visibility" attribute as gcc, we can let the macro definition to allow it under compilation with Clang.
Attachments
Patch (1.31 KB, patch)
2011-11-17 00:22 PST, Hajime Morrita 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hajime Morrita
Comment 1 2011-11-17 00:22:39 PST
Created attachment 115539 [details] Patch
Simon Hausmann
Comment 2 2011-11-17 00:29:04 PST
Comment on attachment 115539 [details] Patch Hm, I think the best way to write this expression is: #elif COMPILER(GCC) || COMPILER(CLANG) #COMPILER(GCC) implies __GNUC__ && !COMPILER(RVCT) and COMPILER(RVCT) is __CC_ARM or __ARMCC__ However I'm somewhat surprised CLANG doesn't identify itself as gcc (for compatibility).
Hajime Morrita
Comment 3 2011-11-17 00:34:19 PST
> However I'm somewhat surprised CLANG doesn't identify itself as gcc (for compatibility). Whoa, good point. It actually knows __GNUC__. This patch is invalid.
Note You need to log in before you can comment on or make changes to this bug.