Bug 72369

Summary: media/track/track-webvtt-tc003-newlines.html is flaky
Product: WebKit Reporter: Tony Gentilcore <tonyg>
Component: WebCore Misc.Assignee: Anna Cavender <annacc>
Status: RESOLVED FIXED    
Severity: Normal CC: eric.carlson, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 72215    
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Tony Gentilcore
Reported 2011-11-15 02:33:09 PST
media/track/track-webvtt-tc003-newlines.html has been flaky since it was introduced by r100085. http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=media%2Ftrack%2Ftrack-webvtt-tc003-newlines.html I'm marking it flaky for now.
Attachments
Patch (1.32 KB, patch)
2011-11-15 02:35 PST, Tony Gentilcore 		no flags
DetailsFormatted DiffDiff
Patch (2.77 KB, patch)
2011-11-15 10:16 PST, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Patch for landing (2.77 KB, patch)
2011-11-15 10:24 PST, Anna Cavender 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tony Gentilcore
Comment 1 2011-11-15 02:35:20 PST
Created attachment 115131 [details] Patch
Tony Gentilcore
Comment 2 2011-11-15 02:37:20 PST
Committed r100257: <http://trac.webkit.org/changeset/100257>
Anna Cavender
Comment 3 2011-11-15 10:16:58 PST
Created attachment 115191 [details] Patch change guarantees tests will run in order
Tony Gentilcore
Comment 4 2011-11-15 10:23:21 PST
Comment on attachment 115191 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115191&action=review Thanks again for jumping on this flakiness so quickly. A couple of minor suggestions inline. > LayoutTests/media/track/track-webvtt-tc003-newlines.html:14 > + numberOfTracksLoaded++; Probably best to "var numberOfTracksLoaded = 0" up on line 9 or 10. > LayoutTests/media/track/track-webvtt-tc003-newlines.html:17 > + testTrack(1); This is a bit more future proof and the same number of lines: for (var i = 0; i < numberOfTrackTests; i++) testTrack(i);
Anna Cavender
Comment 5 2011-11-15 10:24:33 PST
Created attachment 115193 [details] Patch for landing
WebKit Review Bot
Comment 6 2011-11-15 11:30:06 PST
Comment on attachment 115193 [details] Patch for landing Clearing flags on attachment: 115193 Committed r100299: <http://trac.webkit.org/changeset/100299>
WebKit Review Bot
Comment 7 2011-11-15 11:30:11 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.