Bug 72321

Summary: Make ImageFrame member getAddr() public
Product: WebKit Reporter: noel gordon <noel.gordon>
Component: New BugsAssignee: noel gordon <noel.gordon>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 59670    
Attachments:
Description Flags
Patch
none
Patch none

noel gordon
Reported 2011-11-14 15:39:46 PST
Make ImageFrame member getAddr() public
Attachments
Patch (2.20 KB, patch)
2011-11-14 15:41 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
Patch (2.62 KB, patch)
2011-11-14 18:15 PST, noel gordon 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
noel gordon
Comment 1 2011-11-14 15:41:58 PST
Created attachment 115046 [details] Patch
Adam Barth
Comment 2 2011-11-14 17:24:00 PST
Comment on attachment 115046 [details] Patch The ChangeLog needs to explain why we're making this change.
noel gordon
Comment 3 2011-11-14 17:26:57 PST
Would something like https://bugs.webkit.org/show_bug.cgi?id=59670#c8 be enough?
Adam Barth
Comment 4 2011-11-14 17:31:06 PST
Not really. Sure, we could make the function public, but why would we want to? As a general rule, we prefer to limit the visibility of functions. Unless there's a reason to make it public, we'll probably leave it private.
noel gordon
Comment 5 2011-11-14 18:14:50 PST
Ok, lemme better explain it then ...
noel gordon
Comment 6 2011-11-14 18:15:46 PST
Created attachment 115079 [details] Patch
Adam Barth
Comment 7 2011-11-14 18:16:55 PST
Comment on attachment 115079 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=115079&action=review > Source/WebCore/ChangeLog:12 > + Make ImageFrame member getAddr() public to allow ImageFrame users access to the > + underlying frame pixels if needed. Image decoders, for example, could with care > + use this service to write decoded pixels direct to the ImageFrame pixel buffer, > + avoiding intermeadiate data copies from temporary decoded pixel row buffers and > + the decoding performance loss that that entails. Is there an example of an image decoder that would benefit from this API?
noel gordon
Comment 8 2011-11-14 18:18:49 PST
> Is there an example of an image decoder that would benefit from this API? libturbo-jpeg would be one example.
Adam Barth
Comment 9 2011-11-14 18:37:50 PST
Comment on attachment 115079 [details] Patch Ok
WebKit Review Bot
Comment 10 2011-11-15 01:36:52 PST
Comment on attachment 115079 [details] Patch Clearing flags on attachment: 115079 Committed r100252: <http://trac.webkit.org/changeset/100252>
WebKit Review Bot
Comment 11 2011-11-15 01:36:57 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.