Bug 72240

Created attachment 114881 [details] webkit-patch rebaseline-expectations

Attachment 114881 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Last 3072 characters of output: arent-src-synchronously.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3851: Path does not exist. svg/custom/getBBox-path.svg [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3853: Path does not exist. svg/zoom/page/zoom-svg-as-relative-image.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3854: Path does not exist. svg/zoom/page/relative-sized-document-scrollbars.svg [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3856: Path does not exist. storage/indexeddb/key-type-array.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3858: Path does not exist. storage/indexeddb/factory-deletedatabase-interactions.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3860: Path does not exist. fast/js/array-functions-non-arrays.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3861: Path does not exist. fast/js/eval-cross-window.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3862: Path does not exist. fast/js/regexp-caching.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3863: Path does not exist. fast/js/toString-overrides.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3864: Path does not exist. fast/js/toString-recursion.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3865: Path does not exist. http/tests/security/xss-eval.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3867: Path does not exist. fast/dom/javascript-url-exception-isolation.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3868: Path does not exist. fast/borders/inline-mask-overlay-image-outset-vertical-rl.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3870: Path does not exist. fast/dom/rtl-scroll-to-leftmost-and-resize.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3872: Path does not exist. http/tests/inspector/resource-tree/appcache-iframe-manifests.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3874: Path does not exist. accessibility/adjacent-continuations-cause-assertion-failure.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3876: Path does not exist. inspector/debugger/script-formatter.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3879: Path does not exist. fast/js/mozilla/strict/15.4.5.1.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3881: Path does not exist. fast/canvas/canvas-transforms-fillRect-shadow.html [test/expectations] [2] LayoutTests/platform/chromium/test_expectations.txt:3883: Path does not exist. media/track/tracklist-is-reachable.html [test/expectations] [2] Total errors found: 2133 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.

I might buy the Beatles Catalog on iTunes instead :) I was synced to ToT on snow-leopard at the time, warning at the top was: (WARNING: Could not determine the port for LayoutTests/platform/chromium/test_expectations.txt. Using 'test' port, but platform-specific expectations will fail the check. Maybe I need to give a specific platform arg (--platform all) to webkit-patch rebaseline-expectations or some such ...

I bet Eric broke this with his recent changes to how we get the port object.

How do I test this?

Fixed on http://trac.webkit.org/changeset/100231 so a test drive ...

Created attachment 115110 [details] It's getting better all the time ...

Comment on attachment 115110 [details] It's getting better all the time ... OK.

Why did it need rebaseline?

Comment on attachment 115110 [details] It's getting better all the time ... Clearing flags on attachment: 115110 Committed r100264: <http://trac.webkit.org/changeset/100264>

All reviewed patches have been landed. Closing bug.

(In reply to comment #9) > Why did it need rebaseline? Had "Rebaseline" on my brain for some reason, and wrongly. No rebaseline needed, we're adding missing expectations. Will re-title the bug, and link back to the issue at hand.