Bug 71941
| Summary: | [plugins tests] No way to override the default plugin search paths | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | vanuan |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED CONFIGURATION CHANGED | ||
| Severity: | Normal | CC: | aroben, dglazkov, eric, mrobinson, ossy, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | PC | ||
| OS: | Linux | ||
| Bug Depends on: | |||
| Bug Blocks: | 64491 | ||
vanuan
Currently if one has a plugin which is printing to stdout, the tests involving that plugin would fail:
--- WebKit/WebKitBuild/Release/layout-test-results/plugins/embed-attributes-style-expected.txt
+++ WebKit/WebKitBuild/Release/layout-test-results/plugins/embed-attributes-style-actual.txt
@@ -1,3 +1,10 @@
+argv[0] type video/quicktime
+argv[1] valign top
+argv[0] hidden yes
+argv[1] style border: 1px dashed black
+argv[2] type video/quicktime
+argv[0] type video/quicktime
+argv[1] border 5px solid black
layer at (0,0) size 800x600
RenderView at (0,0) size 800x600
layer at (0,0) size 800x600
Is there any way to make webkit to NOT search plugins in default paths when running tests?
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Eric Seidel (no email)
I'm confused as to what you're asking for.
You've modified TestPlugin to print to stdout? Or some other plugin on your system?
vanuan
I have a plugin installed in my system in /usr/lib/mozilla/plugins/.
Apparently it writes to stdout when it is embedded on page. So that plugins/embed-attributes-style.html test is failing.
I'm asking for an option to continue use a plugin installed in my system, but in the same time to be able to run webkit tests without failures. Otherwise I would be forced to use a completely new operating system installation specifically for running webkit tests.
Currently plugins paths are hardcoded in WebKit/Source/WebCore/plugins/PluginDatabase.cpp
It would be better if an option existed to skip default plugins directories when running tests.
Eric Seidel (no email)
This seems like a reasonable request. It has more to do with DumpRenderTree, than with new-run-webkit-tests. But totally doable.
Does the test pass when running with old-run-webkit-tests?
It seems that Qt and Gtk do modify the plugin path in ORWT:
http://trac.webkit.org/browser/trunk/Tools/Scripts/old-run-webkit-tests#L1515
If this test passes in ORWT, then this may be a dupe of bug 68691.
vanuan
Nope, running with OWRT also fails. And IMHO it has nothing to do with locale dependent tests.
As I see in the code http://trac.webkit.org/browser/trunk/Source/WebCore/plugins/PluginDatabase.cpp#L364 default paths are hard coded and setting environment variable can't change that. Maybe I'm missing something? Maybe there's a way to skip defaultPluginDirectories?
Eric Seidel (no email)
The locale-dependent bug is just a bug about the fact that NRWT uses the current shell ENV, where as ORWT used a clean env. As you note though, this bug has to do with the fact that the PluginDatabase has a hardcoded list.
Seems like a useful testing feature to make it possible to disable/override that hard-coded list. Might be a good use for the fancy new "internals" object exposed by WebCore during testing.
Martin Robinson
Support for plugins was removed in https://trac.webkit.org/changeset/265753/webkit.
Radar WebKit Bug Importer
<rdar://problem/96050343>