Bug 71567

Summary: [NRWT] Make single_test_runner aware of test_input.ref_file.
Product: WebKit Reporter: Hayato Ito <hayato>
Component: Tools / TestsAssignee: Hayato Ito <hayato>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dpranke, ojan, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66295    
Attachments:
Description Flags
WIP.
none
aware test_input.ref_file rniwa: review+

Hayato Ito
Reported 2011-11-04 10:12:57 PDT
To support w3c reftests, single_test_runner should be aware of test_input.ref_file (which depends on bug 66937). If the ref_file is given, single_test_runner should use that file as reference_file of the test, instead of trying to find '-expected.html' file.
Attachments
WIP. (5.65 KB, patch)
2011-11-04 10:44 PDT, Hayato Ito 		no flags
DetailsFormatted DiffDiff
aware test_input.ref_file (7.19 KB, patch)
2011-11-08 21:09 PST, Hayato Ito 		rniwa: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Hayato Ito
Comment 1 2011-11-04 10:44:25 PDT
Created attachment 113677 [details] WIP.
Hayato Ito
Comment 2 2011-11-04 14:40:14 PDT
This WIP patch should work on the top of the patch in bug 66937, though there remains an issue of displaying the result. See bug 71574. I'll add tests later.
Ojan Vafai
Comment 3 2011-11-07 23:27:11 PST
Comment on attachment 113677 [details] WIP. Does this break the existing reftests? If we can keep this working, then we can commit this patch without waiting for bug 66837 to be resolved. Eventually, whether we use manifests or link elements, we can populate the test_input element appropriately to make this code work.
Ryosuke Niwa
Comment 4 2011-11-07 23:29:49 PST
(In reply to comment #3) > (From update of attachment 113677 [details]) > Does this break the existing reftests? If we can keep this working, then we can commit this patch without waiting for bug 66837 to be resolved. Eventually, whether we use manifests or link elements, we can populate the test_input element appropriately to make this code work. I don't think it makes sense to land this patch unless we're parsing reftest.list. Since we don't need to pass any information from manager to single_test_runner if we're parsing link element.
Hayato Ito
Comment 5 2011-11-08 00:50:10 PST
(In reply to comment #3) > (From update of attachment 113677 [details]) > Does this break the existing reftests? If we can keep this working, then we can commit this patch without waiting for bug 66837 to be resolved. Eventually, whether we use manifests or link elements, we can populate the test_input element appropriately to make this code work. Yes, this patch is intended to work on either we use manifest file or link elements. I assumed that caller should pass reference file name. It is possible to make this patch not break existing reftests and independent of bug 66837.
Hayato Ito
Comment 6 2011-11-08 21:09:04 PST
Created attachment 114202 [details] aware test_input.ref_file
Hayato Ito
Comment 7 2011-11-08 21:18:47 PST
I'll land this patch. The patch now works without bug 66837 and doesn't not break existing reftests. I'll address bug 71574, which also doesn't affect existing reftests, later.
Hayato Ito
Comment 8 2011-11-08 21:45:12 PST
Committed r99651: <http://trac.webkit.org/changeset/99651>
Note You need to log in before you can comment on or make changes to this bug.