Bug 71485

Summary: [Chromium] Rename WebView::scalePage to WebView::setPageScaleFactor to match WebCore
Product: WebKit Reporter: Fady Samuel <fsamuel>
Component: WebKit APIAssignee: Fady Samuel <fsamuel>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, tkent, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70559, 71622    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Fady Samuel
Reported 2011-11-03 10:41:18 PDT
Need to first get rid of the hack in Chromium renderer to set page scale factor because it's currently broken after a refactoring. Will post Chromium side + WebKit side changes shortly. The Chromium side change needs to land first.
Attachments
Patch (5.94 KB, patch)
2011-11-05 19:48 PDT, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (6.23 KB, patch)
2011-11-07 09:59 PST, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Patch (6.23 KB, patch)
2011-11-07 10:12 PST, Fady Samuel 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Fady Samuel
Comment 1 2011-11-05 19:48:11 PDT
Created attachment 113776 [details] Patch
WebKit Review Bot
Comment 2 2011-11-05 19:52:49 PDT
Please wait for approval from fishd@chromium.org before submitting because this patch contains changes to the Chromium public API.
Darin Fisher (:fishd, Google)
Comment 3 2011-11-07 09:22:55 PST
Comment on attachment 113776 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113776&action=review > Source/WebKit/chromium/public/WebView.h:220 > + virtual void setPageScaleFactor(float scaleFactor, WebPoint origin) = 0; nit: while you are at it, the WebPoint parameter should probably be passed as "const WebPoint&"
Fady Samuel
Comment 4 2011-11-07 09:59:04 PST
Created attachment 113885 [details] Patch
Fady Samuel
Comment 5 2011-11-07 10:12:19 PST
Created attachment 113887 [details] Patch
Fady Samuel
Comment 6 2011-11-07 10:24:56 PST
Comment on attachment 113887 [details] Patch Clearing flags on attachment: 113887 Committed r99440: <http://trac.webkit.org/changeset/99440>
Fady Samuel
Comment 7 2011-11-07 10:25:02 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.