Bug 71280

Summary: [Qt] Merge common desktop and touch APIs under an abstract base class.
Product: WebKit Reporter: Jocelyn Turcotte <jturcotte>
Component: New BugsAssignee: Jocelyn Turcotte <jturcotte>
Status: RESOLVED FIXED    
Severity: Normal CC: hausmann, menard, vestbo, webkit.review.bot, zalan, zoltan
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 71311    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch none

Jocelyn Turcotte
Reported 2011-11-01 04:41:53 PDT
[Qt] Merge common desktop and touch APIs under an abstract base class.
Attachments
Patch (55.46 KB, patch)
2011-11-01 04:52 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Patch (57.67 KB, patch)
2011-11-01 08:31 PDT, Jocelyn Turcotte 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jocelyn Turcotte
Comment 1 2011-11-01 04:52:44 PDT
Created attachment 113157 [details] Patch
WebKit Review Bot
Comment 2 2011-11-01 04:54:03 PDT
Attachment 113157 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/qt/qabstractwebview_p.h:35: q_ptr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit2/UIProcess/API/qt/qabstractwebview.h:85: d_ptr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 19 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexis Menard (darktears)
Comment 3 2011-11-01 05:23:00 PDT
Comment on attachment 113157 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113157&action=review Usually in Qt abstract classes have at least one pure virtual method. > Source/WebKit2/UIProcess/API/qt/qabstractwebview.h:59 > + // FIXME: We inherit from QSGPaintedItem until QDesktopWebView works on top of a plain QSGItem. QQuickPaintedItem rather than QSGPaintedItem. QSGItem -> QQuickItem > Source/WebKit2/UIProcess/API/qt/qabstractwebview.h:80 > + void linkHovered(const QUrl& url, const QString& title); I think this should be only in the desktopwebview for now.
Jocelyn Turcotte
Comment 4 2011-11-01 08:31:49 PDT
Created attachment 113174 [details] Patch - Renamed QAbstractWebView to QBaseWebView. - renamed QtWebPageProxy instances from page to pageProxy. - Changed the type of QTouchWebPagePrivate::pageProxy from QtTouchWebPageProxy to QtWebPageProxy to make its scope simillar to Q*WebView. - Moved linkHovered back to QDesktopWebView.
WebKit Review Bot
Comment 5 2011-11-01 08:38:27 PDT
Attachment 113174 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/UIProcess/API/qt/qbasewebview_p.h:35: q_ptr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Source/WebKit2/UIProcess/API/qt/qbasewebview.h:84: d_ptr is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 2 in 21 files If any of these errors are false positives, please file a bug against check-webkit-style.
Andreas Kling
Comment 6 2011-11-01 10:00:02 PDT
Comment on attachment 113174 [details] Patch Me gusta.
Jocelyn Turcotte
Comment 7 2011-11-01 10:05:42 PDT
Comment on attachment 113174 [details] Patch Clearing flags on attachment: 113174 Committed r98973: <http://trac.webkit.org/changeset/98973>
Jocelyn Turcotte
Comment 8 2011-11-01 10:05:50 PDT
All reviewed patches have been landed. Closing bug.
Alexis Menard (darktears)
Comment 9 2011-11-01 13:52:40 PDT
(In reply to comment #8) > All reviewed patches have been landed. Closing bug. http://build.webkit.sed.hu/builders/x86-32%20Linux%20Qt%20Release%20WebKit2/builds/14403/steps/API%20tests/logs/stdio it broke the QML API tests.
Jocelyn Turcotte
Comment 10 2011-11-02 09:48:23 PDT
Fixed the API tests. Committed r99073: <http://trac.webkit.org/changeset/99073>
Note You need to log in before you can comment on or make changes to this bug.