Bug 71178

Summary:

Add TrackEvent

Product:

WebKit

Reporter:

Eric Carlson <eric.carlson>

Component:

Media

Assignee:

Eric Carlson <eric.carlson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, annacc, dglazkov, gustavo.noronha, gustavo, japhet, ojan, sam, webkit-bug-importer, webkit.review.bot, xan.lopez

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

63042

Attachments:

Description	Flags
Patch	gustavo: commit-queue-
Updated patch	webkit-ews: commit-queue-
Yet another patch for the EWS bots to chew up and spit out.	gustavo.noronha: commit-queue-
Updated patch	webkit.review.bot: commit-queue-
Another patch	none
Another patch, hopefully the right version this time.	webkit.review.bot: commit-queue-
This might be the one.	sam: review+

Eric Carlson

Reported 2011-10-29 12:28:51 PDT

http://www.whatwg.org/specs/web-apps/current-work/multipage/the-video-element.html#trackevent defines the TrackEvent, needed for the TextTrack 'addtrack' event.

Attachments
Patch (60.10 KB, patch) 2011-11-01 13:49 PDT, Eric Carlson	gustavo: commit-queue-	Details Formatted Diff Diff
Updated patch (62.31 KB, patch) 2011-11-01 22:02 PDT, Eric Carlson	webkit-ews: commit-queue-	Details Formatted Diff Diff
Yet another patch for the EWS bots to chew up and spit out. (62.30 KB, patch) 2011-11-02 09:49 PDT, Eric Carlson	gustavo.noronha: commit-queue-	Details Formatted Diff Diff
Updated patch (63.43 KB, patch) 2011-11-02 11:50 PDT, Eric Carlson	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
Another patch (63.54 KB, patch) 2011-11-02 14:44 PDT, Eric Carlson	no flags	Details Formatted Diff Diff
Another patch, hopefully the right version this time. (64.57 KB, patch) 2011-11-02 15:29 PDT, Eric Carlson	webkit.review.bot: commit-queue-	Details Formatted Diff Diff
This might be the one. (63.53 KB, patch) 2011-11-03 07:41 PDT, Eric Carlson	sam: review+	Details Formatted Diff Diff
Show Obsolete (6) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2011-10-29 12:29:12 PDT

<rdar://problem/10367475>

Eric Carlson

Comment 2 2011-11-01 13:49:37 PDT

Created attachment 113208 [details] Patch Preliminary patch so the EWS bots can point out any obvious problems.

WebKit Review Bot

Comment 3 2011-11-01 13:51:21 PDT

Attachment 113208 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/html/track/TrackBase.h:26: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:38: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:41: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:48: track_event is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 4 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.

Gustavo Noronha (kov)

Comment 4 2011-11-01 13:58:41 PDT

Comment on attachment 113208 [details] Patch Attachment 113208 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10128379

Early Warning System Bot

Comment 5 2011-11-01 14:05:31 PDT

Comment on attachment 113208 [details] Patch Attachment 113208 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10148035

Eric Carlson

Comment 6 2011-11-01 14:13:32 PDT

(In reply to comment #5) > (From update of attachment 113208 [details]) > Attachment 113208 [details] did not pass qt-ews (qt): > Output: http://queues.webkit.org/results/10148035 Oops, I forgot to surround the TrackEvent initialization constructor in EventConstructors.h with "#if ENABLE(VIDEO_TRACK)"

WebKit Review Bot

Comment 7 2011-11-01 14:26:26 PDT

Comment on attachment 113208 [details] Patch Attachment 113208 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10257045

Sam Weinig

Comment 8 2011-11-01 14:44:04 PDT

Comment on attachment 113208 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=113208&action=review > Source/WebCore/bindings/generic/EventConstructors.h:142 > +#define INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_TRACK_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY) \ > + \ > + DICTIONARY_START(TrackEvent) \ > + FILL_PARENT_PROPERTIES(Event) \ > + FILL_PROPERTY(track) \ > + DICTIONARY_END(TrackEvent) This probably needs #ifdefing.

Eric Carlson

Comment 9 2011-11-01 14:52:43 PDT

(In reply to comment #8) > (From update of attachment 113208 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=113208&action=review > > > Source/WebCore/bindings/generic/EventConstructors.h:142 > > +#define INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_TRACK_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY) \ > > + \ > > + DICTIONARY_START(TrackEvent) \ > > + FILL_PARENT_PROPERTIES(Event) \ > > + FILL_PROPERTY(track) \ > > + DICTIONARY_END(TrackEvent) > > This probably needs #ifdefing. See comment #6 ;-)

Daniel Bates

Comment 10 2011-11-01 18:44:39 PDT

Comment on attachment 113208 [details] Patch Attachment 113208 [details] did not pass mac-ews (mac): Output: http://queues.webkit.org/results/10257115

Eric Carlson

Comment 11 2011-11-01 22:02:30 PDT

Created attachment 113277 [details] Updated patch This patch is being uploaded so the EWS bots can see if it compiles. It is not marked for review so there is no need to mark it cq- if it fails to compile.

WebKit Review Bot

Comment 12 2011-11-01 22:06:07 PDT

Attachment 113277 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/html/track/TrackBase.h:26: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:41: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:48: track_event is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 3 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 13 2011-11-01 22:14:13 PDT

Comment on attachment 113277 [details] Updated patch Attachment 113277 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10148134

WebKit Review Bot

Comment 14 2011-11-01 22:29:08 PDT

Comment on attachment 113277 [details] Updated patch Attachment 113277 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10257169

Collabora GTK+ EWS bot

Comment 15 2011-11-02 03:46:46 PDT

Comment on attachment 113277 [details] Updated patch Attachment 113277 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10259213

Eric Carlson

Comment 16 2011-11-02 09:49:49 PDT

Created attachment 113323 [details] Yet another patch for the EWS bots to chew up and spit out.

WebKit Review Bot

Comment 17 2011-11-02 09:52:40 PDT

Attachment 113323 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/html/track/TrackBase.h:26: Tab found; better to use spaces [whitespace/tab] [1] Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:41: Alphabetical sorting problem. [build/include_order] [4] Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:48: track_event is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 3 in 40 files If any of these errors are false positives, please file a bug against check-webkit-style.

Collabora GTK+ EWS bot

Comment 18 2011-11-02 10:02:08 PDT

Comment on attachment 113323 [details] Yet another patch for the EWS bots to chew up and spit out. Attachment 113323 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10258293

WebKit Review Bot

Comment 19 2011-11-02 10:24:48 PDT

Comment on attachment 113323 [details] Yet another patch for the EWS bots to chew up and spit out. Attachment 113323 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10256315

Eric Carlson

Comment 20 2011-11-02 11:50:57 PDT

Created attachment 113344 [details] Updated patch This should build on GTK thanks to Philippe Normand.

WebKit Review Bot

Comment 21 2011-11-02 11:54:36 PDT

Attachment 113344 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:47: track_event is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

WebKit Review Bot

Comment 22 2011-11-02 12:20:57 PDT

Comment on attachment 113344 [details] Updated patch Attachment 113344 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10128682

Eric Carlson

Comment 23 2011-11-02 14:44:34 PDT

Created attachment 113381 [details] Another patch This should compile, lets see if it links.

WebKit Review Bot

Comment 24 2011-11-02 15:18:16 PDT

Attachment 113381 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/fast..." exit_code: 1 Source/WebCore/bindings/v8/custom/V8TrackEventCustom.cpp:47: track_event is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4] Total errors found: 1 in 42 files If any of these errors are false positives, please file a bug against check-webkit-style.

Eric Carlson

Comment 25 2011-11-02 15:29:22 PDT

Created attachment 113386 [details] Another patch, hopefully the right version this time.

WebKit Review Bot

Comment 26 2011-11-02 16:07:45 PDT

Comment on attachment 113386 [details] Another patch, hopefully the right version this time. Attachment 113386 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10175412

Eric Carlson

Comment 27 2011-11-03 07:41:16 PDT

Created attachment 113489 [details] This might be the one.

Sam Weinig

Comment 28 2011-11-03 09:14:43 PDT

Comment on attachment 113489 [details] This might be the one. View in context: https://bugs.webkit.org/attachment.cgi?id=113489&action=review > Source/WebCore/html/track/TrackEvent.h:64 > + virtual bool isTrackEvent() const { return true; } This is no longer needed.

Eric Carlson

Comment 29 2011-11-03 21:20:53 PDT

http://trac.webkit.org/changeset/99261

Note You need to log in before you can comment on or make changes to this bug.