Bug 70940

Summary: [Chromium] Investigate where/when webView->resetGestureRecognizer should be called
Product: WebKit Reporter: Fady Samuel <fsamuel>
Component: UI EventsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED WONTFIX    
Severity: Normal CC: dglazkov, fishd, rjkroege, schenney, varunjain
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 70507    
Bug Blocks:    

Fady Samuel
Reported 2011-10-26 10:11:35 PDT
It strikes me as odd that resetGestureRecognizer is called in WebFrameImpl::createFrameView...this is called for every subframe of a page, and for subframe navigation too! Here's a scenario where I expect this might break: You have a rotating ad (the iframe navigates to a different page every few seconds), and on every navigation WebFrameImpl::createFrameView is called. Suppose you're in the process of doing a pinch-to-zoom gesture, and the iframe's src changes during that gesture. Now the gesture recognizer will get reset. I haven't confirmed this actually happens but I suspect it might. I am currently in the process of refactoring WebFrameImpl::createFrameView().
Attachments
Note You need to log in before you can comment on or make changes to this bug.