Bug 70782
| Summary: | Implement visibility:collapse for new flexboxes | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Ojan Vafai <ojan> |
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | hyatt, jchaffraix, tabatkins, tony |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Bug Depends on: | |||
| Bug Blocks: | 62048 | ||
Ojan Vafai
The current spec text is "Similar to table cells, flexbox items respond specially to the ‘collapse’ value of the ‘visibility’ property. When a flexbox item is set to ‘visibility: collapse;’, the item does not generate a box at all (identical to setting ‘display: none;’)."
There's a bit of controversy over whether this is the right thing to do: http://lists.w3.org/Archives/Public/www-style/2011Oct/0136.html. If we could get away with changing visibility:collapse across the board without compat problems, that would clearly be best.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Ojan Vafai
The spec has changed to not mention visibility:collapse at all, which means that we should treat it as visibility:hidden. I expect this just works right now, but we should add some tests to verify.
Ojan Vafai
The spec has changed to require special visibility:collapse behavior. http://dev.w3.org/csswg/css3-flexbox/#visibility-collapse
I don't especially love this behavior, but I don't care enough to argue it.
Tony Chang
Here's a test case:
http://plexode.com/u/#2J%222I%3E2H%3CEG8world29%3AfGHbrIr7*1459!16hello(E6JIf5!-webkit-flexr4px!solid!blue%3Br*!!)Jborder9!n)Hdiv!style%3Dn(H%2FdivI%0A2!%20~http://plexode.com/eval3/#ht=)Jdisplay95%3B6%0A7*14!visibility9collapse68G(7(
Basically, the middle div should have 0 width, but the height of the flexbox should be unchanged. Currently, it creates width.