Bug 70693

Summary: [Qt][WK2] QDesktopWebView and QTouchWebView should be declared in the meta type system.
Product: WebKit Reporter: Zeno Albisser <zeno>
Component: WebKit QtAssignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 70315    
Attachments:
Description Flags
patch for review.
vestbo: review-
patch for review. none

Zeno Albisser
Reported 2011-10-23 05:58:19 PDT
Without that we cannot use these types in the template based functions of the meta type system. (QVariant) If we instantiate a QDesktopWebView or a QTouchWebView in QML but want to acess it also in C++, then we need to ask the meta type system in c++ for the type of the object.
Attachments
patch for review. (1.57 KB, patch)
2011-10-23 06:05 PDT, Zeno Albisser 		vestbo: review-
DetailsFormatted DiffDiff
patch for review. (1.60 KB, patch)
2011-10-23 13:51 PDT, Zeno Albisser 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zeno Albisser
Comment 1 2011-10-23 06:05:22 PDT
Created attachment 112109 [details] patch for review. is there a good reason why we should not do that?
Tor Arne Vestbø
Comment 2 2011-10-23 12:49:16 PDT
Comment on attachment 112109 [details] patch for review. Yepp, this is the place we should do it. But it should be QML_DECLARE_TYPE(QTouchWebView), to get the pointer automatically and cover the list-usecase. http://doc.qt.nokia.com/4.7-snapshot/qdeclarativeengine.html#QML_DECLARE_TYPE
Zeno Albisser
Comment 3 2011-10-23 13:51:01 PDT
Created attachment 112125 [details] patch for review.
Simon Hausmann
Comment 4 2011-10-25 05:31:08 PDT
Comment on attachment 112125 [details] patch for review. r=me
WebKit Review Bot
Comment 5 2011-10-25 06:37:36 PDT
Comment on attachment 112125 [details] patch for review. Clearing flags on attachment: 112125 Committed r98337: <http://trac.webkit.org/changeset/98337>
WebKit Review Bot
Comment 6 2011-10-25 06:37:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.