Bug 70180

Summary: [GTK] GtkAdjustment watcher updates adjustments too lazily
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: cgarcia, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68757    
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2011-10-15 14:05:27 PDT
The timeout GtkAdjustmentWatcher::updateAdjustmentsFromScrollbarsLater has a low enough priority that sometimes scrollbars become out of sync with the page contents. I've seen this cause drawing artifacts as well. We just need to boost the priority slightly.
Attachments
Patch (2.41 KB, patch)
2011-10-15 14:11 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-10-15 14:11:00 PDT
Created attachment 111144 [details] Patch
Carlos Garcia Campos
Comment 2 2011-10-16 23:45:52 PDT
Comment on attachment 111144 [details] Patch LGTM
Gustavo Noronha (kov)
Comment 3 2011-10-24 05:45:33 PDT
Comment on attachment 111144 [details] Patch I hate these priority problems =( I think it makes sense as it is, but just out of curiosity, did you try having it set to something like G_PRIORITY_HIGH_IDLE itself, which would guarantee it's ran before any GTK+ layout is performed?
Martin Robinson
Comment 4 2011-10-25 09:38:33 PDT
Comment on attachment 111144 [details] Patch Landing this now, since I think Alex wants it for the release. To answer kov's question, I'm pretty sure I did test G_PRIORITY_HIGH_IDLE without much luck.
WebKit Review Bot
Comment 5 2011-10-25 09:51:57 PDT
Comment on attachment 111144 [details] Patch Clearing flags on attachment: 111144 Committed r98352: <http://trac.webkit.org/changeset/98352>
WebKit Review Bot
Comment 6 2011-10-25 09:52:02 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.