Bug 69882

Summary: Move selectionStartStyle and selectionHasStyle to EditingStyle
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: darin, enrica, leviw, morrita, sullivan, tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 54932, 70114    
Attachments:
Description Flags
cleanup
none
Fixed changelog none

Ryosuke Niwa
Reported 2011-10-11 16:53:41 PDT
Some functions in EditingStyle are exposed globally because of selectionStartStyle and selectionHasStyle. We should move these functions to EditingStyle to better encapsulate style-related editing functions.
Attachments
cleanup (24.95 KB, patch)
2011-10-12 11:41 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Fixed changelog (23.96 KB, patch)
2011-10-12 11:42 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-10-12 11:41:38 PDT
Created attachment 110713 [details] cleanup
Ryosuke Niwa
Comment 2 2011-10-12 11:42:30 PDT
Created attachment 110714 [details] Fixed changelog
Enrica Casucci
Comment 3 2011-10-13 10:22:25 PDT
Comment on attachment 110714 [details] Fixed changelog View in context: https://bugs.webkit.org/attachment.cgi?id=110714&action=review > Source/WebCore/editing/Editor.cpp:557 > +#endif I thought you wanted to move this to EditorMac. Why did you change your mind? > Source/WebCore/editing/Editor.cpp:2833 > +#endif Ditto.
Ryosuke Niwa
Comment 4 2011-10-13 10:42:57 PDT
Comment on attachment 110714 [details] Fixed changelog View in context: https://bugs.webkit.org/attachment.cgi?id=110714&action=review >> Source/WebCore/editing/Editor.cpp:557 >> +#endif > > I thought you wanted to move this to EditorMac. Why did you change your mind? That'll be done in a follow up patch :) These functions are exported to WebKit layer and updating symbols and all is a bit troublesome since this patch is already pretty big.
Enrica Casucci
Comment 5 2011-10-14 09:51:48 PDT
Comment on attachment 110714 [details] Fixed changelog Thanks for the explanation. Looks good to me.
Ryosuke Niwa
Comment 6 2011-10-14 09:55:42 PDT
(In reply to comment #5) > (From update of attachment 110714 [details]) > Thanks for the explanation. Looks good to me. Great! Filed the bug 70114 to move the said functions to EditorMac.
Ryosuke Niwa
Comment 7 2011-10-14 10:59:30 PDT
Comment on attachment 110714 [details] Fixed changelog Clearing flags on attachment: 110714 Committed r97480: <http://trac.webkit.org/changeset/97480>
Ryosuke Niwa
Comment 8 2011-10-14 10:59:33 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.