Bug 69241

Summary: Should call checkTextOfParagraph() indirectly to make unifying spell-checking code path ease
Product: WebKit Reporter: Shinya Kawanaka <shinyak>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: rniwa, shinyak, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 69128    
Attachments:
Description Flags
Patch
none
Patch none

Shinya Kawanaka
Reported 2011-10-02 22:48:01 PDT
Editor class has two difference code paths for spell-checking: (1) checkTextOfParagraph() for Snow Leopard or later (2) checkSpellingOfString() and checkGrammarOfString() for other platforms. These paths should be unified so that improving spell-checking code is easy. At the first step, we should call checkTextOfParagraph() indirectly so that we can implement a function to mimic checkTextOfParagraph() in non-SL or non-Lion platform.
Attachments
Patch (7.60 KB, patch)
2011-10-02 23:03 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Patch (7.57 KB, patch)
2011-10-03 02:23 PDT, Shinya Kawanaka 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Shinya Kawanaka
Comment 1 2011-10-02 23:03:25 PDT
Created attachment 109440 [details] Patch
Ryosuke Niwa
Comment 2 2011-10-02 23:33:22 PDT
Comment on attachment 109440 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109440&action=review > Source/WebCore/ChangeLog:12 > + At the first step, this patch introduces an indirect wrappero to call Typo: wrappero > Source/WebCore/editing/TextCheckingHelper.h:96 > + TextCheckingTypeMask checkingTypes, Vector<TextCheckingResult>& results); Nit: indentation is wrong here. TextCheckingTypeMask should be indented by exactly 4 spaces, and should NOT be aligned with TextCheckerClient.
Shinya Kawanaka
Comment 3 2011-10-03 02:23:48 PDT
Created attachment 109454 [details] Patch
WebKit Review Bot
Comment 4 2011-10-03 20:10:00 PDT
Comment on attachment 109454 [details] Patch Clearing flags on attachment: 109454 Committed r96568: <http://trac.webkit.org/changeset/96568>
WebKit Review Bot
Comment 5 2011-10-03 20:10:04 PDT
All reviewed patches have been landed. Closing bug.
Ryosuke Niwa
Comment 6 2011-10-03 21:16:21 PDT
This patch broke builds pretty badly :( build fixes: http://trac.webkit.org/changeset/96570 http://trac.webkit.org/changeset/96571
Note You need to log in before you can comment on or make changes to this bug.