Bug 68974

Summary: watchlist: Make watchlist run on a bot.
Product: WebKit Reporter: David Levin <levin>
Component: Tools / TestsAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 69288    
Bug Blocks: 68822    
Attachments:
Description Flags
Patch
none
Patch abarth: review+

David Levin
Reported 2011-09-27 23:14:51 PDT
Likely just run with the stylebot.
Attachments
Patch (8.50 KB, patch)
2011-10-03 14:12 PDT, David Levin 		no flags
DetailsFormatted DiffDiff
Patch (3.43 KB, patch)
2011-10-03 14:13 PDT, David Levin 		abarth: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-10-03 14:12:28 PDT
Created attachment 109528 [details] Patch
David Levin
Comment 2 2011-10-03 14:13:37 PDT
Created attachment 109529 [details] Patch
Adam Barth
Comment 3 2011-10-03 14:17:04 PDT
Comment on attachment 109529 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=109529&action=review > Tools/Scripts/webkitpy/tool/commands/queues_unittest.py:416 > - "process_work_item": "MOCK: update_status: style-queue Pass\nMOCK: release_work_item: style-queue 10000\n", > + "process_work_item": "MOCK run_and_throw_if_fail: ['echo', '--status-host=example.com', 'check-style', '--force-clean', '--non-interactive', '--parent-command=style-queue', 10000], cwd=/mock-checkout\nMOCK run_and_throw_if_fail: ['echo', '--status-host=example.com', 'apply-watchlist-local', 50000], cwd=/mock-checkout\nMOCK: update_status: style-queue Pass\nMOCK: release_work_item: style-queue 10000\n", When these lines get long, we tend to use heredoc comments """blah blah blah""" to make it easier to read (and to see the diffs).
David Levin
Comment 4 2011-10-03 14:44:00 PDT
Committed as http://trac.webkit.org/changeset/96541
Note You need to log in before you can comment on or make changes to this bug.