Bug 68300
| Summary: | Don't use WebPreferences to set global settings | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> |
| Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ap, cmarcelo, mitz |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Simon Fraser (smfr)
There are a few methods on WebPreferences that toggle globals (e.g. AVFoundationEnabled, ShouldPaintNativeControls, MockScrollbarsEnabled, ShouldUseHighResolutionTimers).
These would be better as WebView class methods.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Alexey Proskuryakov
WebPreferences is the thing that syncs with on-disk defaults, so they are all global. Am I confused?
mitz
Standard WebPreferences are persistent by default. A WebView’s preferences can be the standard preferences or any other WebPreferences instance, which may or may not be persistent. The methods mentioned in the Description, however, take effect on all WebViews in the process, regardless of their preferences, and regardless of the WebPreference instance on which those methods are invoked.