Bug 68239

Summary: Depend on harfbuzz for OS=Android as well
Product: WebKit Reporter: Peter Beverloo <peter>
Component: WebCore Misc.Assignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, steveblock, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66689    
Attachments:
Description Flags
Patch
steveblock: review+
Patch none

Peter Beverloo
Reported 2011-09-16 04:30:41 PDT
Android depends on harfbuzz as well, so reflect that in the project file. Furthermore, fix a compile error in PopupListBox.cpp by explicitly including ctype.h, as isspace otherwise won't be enabled.
Attachments
Patch (1.80 KB, patch)
2011-09-16 04:33 PDT, Peter Beverloo 		steveblock: review+
DetailsFormatted DiffDiff
Patch (1.81 KB, patch)
2011-09-16 04:50 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2011-09-16 04:33:14 PDT
Created attachment 107634 [details] Patch
Steve Block
Comment 2 2011-09-16 04:46:17 PDT
Comment on attachment 107634 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107634&action=review > Source/WebCore/ChangeLog:6 > + Android depends on harfbuzz as well, so reflect that in the project 'as well as GTK' > Source/WebCore/ChangeLog:8 > + explicitly including ctype.h, as isspace otherwise won't be enabled. s/enabled/declared ?
Peter Beverloo
Comment 3 2011-09-16 04:50:27 PDT
Created attachment 107637 [details] Patch (In reply to comment #2) > (From update of attachment 107634 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107634&action=review > > > Source/WebCore/ChangeLog:6 > > + Android depends on harfbuzz as well, so reflect that in the project > > 'as well as GTK' That would say that Android depends on GTK too, which is not the case. I've rephrased the sentence. > > > Source/WebCore/ChangeLog:8 > > + explicitly including ctype.h, as isspace otherwise won't be enabled. > > s/enabled/declared ? Done. Thanks!
Steve Block
Comment 4 2011-09-16 04:53:45 PDT
Comment on attachment 107637 [details] Patch r=me
WebKit Review Bot
Comment 5 2011-09-16 19:41:21 PDT
Comment on attachment 107637 [details] Patch Clearing flags on attachment: 107637 Committed r95356: <http://trac.webkit.org/changeset/95356>
WebKit Review Bot
Comment 6 2011-09-16 19:41:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.