Bug 68205

Summary: Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 68012    
Attachments:
Description Flags
Patch
none
Patch
none
Patch eric: review+

Adam Barth
Reported 2011-09-15 18:34:25 PDT
Rename ENABLE(DATABASE) to ENABLE(SQL_DATABASE)
Attachments
Patch (149.53 KB, patch)
2011-09-15 18:36 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (150.04 KB, patch)
2011-09-15 20:51 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (150.47 KB, patch)
2011-09-15 21:51 PDT, Adam Barth 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-09-15 18:36:06 PDT
Created attachment 107581 [details] Patch
Early Warning System Bot
Comment 2 2011-09-15 18:59:47 PDT
Comment on attachment 107581 [details] Patch Attachment 107581 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9706157
Gyuyoung Kim
Comment 3 2011-09-15 19:06:40 PDT
Comment on attachment 107581 [details] Patch Attachment 107581 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9694259
Adam Barth
Comment 4 2011-09-15 20:51:06 PDT
Created attachment 107597 [details] Patch
Early Warning System Bot
Comment 5 2011-09-15 21:11:12 PDT
Comment on attachment 107597 [details] Patch Attachment 107597 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9709054
Adam Barth
Comment 6 2011-09-15 21:51:56 PDT
Created attachment 107602 [details] Patch
Eric Seidel (no email)
Comment 7 2011-09-15 22:08:46 PDT
Comment on attachment 107602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107602&action=review build-webkit changes? You might want to grep for"database_" as well. > configure.ac:1135 > +AM_CONDITIONAL([ENABLE_SQL_DATABASE],[test "$enable_sql_database" = "yes"]) I'm surprised this isn't referenced in more places in this file. > Source/JavaScriptCore/wtf/Platform.h:816 > -#if !defined(ENABLE_DATABASE) > -#define ENABLE_DATABASE 1 > +#if !defined(ENABLE_SQL_DATABASE) > +#define ENABLE_SQL_DATABASE 1 > #endif I thought we'd moved away from this model?
Adam Barth
Comment 8 2011-09-15 22:19:06 PDT
(In reply to comment #7) > (From update of attachment 107602 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107602&action=review > > build-webkit changes? You might want to grep for"database_" as well. Oops. Fixed. > > configure.ac:1135 > > +AM_CONDITIONAL([ENABLE_SQL_DATABASE],[test "$enable_sql_database" = "yes"]) > > I'm surprised this isn't referenced in more places in this file. I'll double-check. > > Source/JavaScriptCore/wtf/Platform.h:816 > > -#if !defined(ENABLE_DATABASE) > > -#define ENABLE_DATABASE 1 > > +#if !defined(ENABLE_SQL_DATABASE) > > +#define ENABLE_SQL_DATABASE 1 > > #endif > > I thought we'd moved away from this model? I think that's the plan, but I'm not sure it's happened yet.
Adam Barth
Comment 9 2011-09-15 22:40:21 PDT
Committed r95271: <http://trac.webkit.org/changeset/95271>
Csaba Osztrogonác
Comment 10 2011-09-16 09:08:47 PDT
Comment on attachment 107602 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107602&action=review > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:235 > -#endif /* ENABLE(DATABASE) */ > +#endif // ENABLE(SQL_DATABASE) This change was incorrect, it broke binding test. Fix landed in http://trac.webkit.org/changeset/95294
Adam Barth
Comment 11 2011-09-16 10:22:41 PDT
(In reply to comment #10) > (From update of attachment 107602 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=107602&action=review > > > Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:235 > > -#endif /* ENABLE(DATABASE) */ > > +#endif // ENABLE(SQL_DATABASE) > > This change was incorrect, it broke binding test. > Fix landed in http://trac.webkit.org/changeset/95294 Thanks for fixing it, but I think that means the code generation script has a (minor!) bug. It should generate C++ style comments. /me will fix.
Adam Barth
Comment 12 2011-09-16 10:39:22 PDT
GObject script fix in https://bugs.webkit.org/show_bug.cgi?id=68256
Note You need to log in before you can comment on or make changes to this bug.