Bug 68107

Summary: [Chromium] Make WEB_AUDIO conditional and fix the build when disabled
Product: WebKit Reporter: Peter Beverloo <peter>
Component: Web AudioAssignee: Peter Beverloo <peter>
Status: RESOLVED FIXED    
Severity: Normal CC: crogers, kbr, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66689    
Attachments:
Description Flags
Patch none

Peter Beverloo
Reported 2011-09-14 12:47:47 PDT
This patch makes the ENABLE_WEB_AUDIO conditional, and fixes the build when it's disabled. Some code in the WebMediaPlayerClientImpl relied on it being enabled.
Attachments
Patch (3.45 KB, patch)
2011-09-14 12:50 PDT, Peter Beverloo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Peter Beverloo
Comment 1 2011-09-14 12:50:24 PDT
Created attachment 107379 [details] Patch
Chris Rogers
Comment 2 2011-09-14 13:02:54 PDT
Hi Peter, this looks fine to me. Later on we can see what it will take to get this working, but it's normal to disable it at this point.
Kenneth Russell
Comment 3 2011-09-14 14:21:38 PDT
Comment on attachment 107379 [details] Patch Looks fine to me.
WebKit Review Bot
Comment 4 2011-09-14 21:14:57 PDT
Comment on attachment 107379 [details] Patch Clearing flags on attachment: 107379 Committed r95160: <http://trac.webkit.org/changeset/95160>
WebKit Review Bot
Comment 5 2011-09-14 21:15:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.