Bug 68046

Summary: WinCE builds with threads turned off
Product: WebKit Reporter: Geoffrey Garen <ggaren>
Component: JavaScriptCoreAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, levin+threading, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 54836, 68068, 68429    
Bug Blocks:    
Attachments:
Description Flags
Patch webkit.review.bot: commit-queue-

Geoffrey Garen
Reported 2011-09-13 18:17:34 PDT
Per email to webkit-dev, we're going to remove the "no threads" #ifdefs from JavaScriptCore and WebKit. Please update the WinCE platform to be compatible with this change. Try this, in Platform.h: Unconditionally set ENABLE_SINGLE_THREADED=0. Unconditionally set ENABLE_JSC_MULTIPLE_THREADS=1. Unconditionally set ENABLE_WTF_MULTIPLE_THREADS=1. Build and see what happens. I believe you'll need to link to libpthread to make the build succeed, or take on more extensive changes. See my suggestions here: https://bugs.webkit.org/show_bug.cgi?id=67864.
Attachments
Patch (8.30 KB, patch)
2011-11-17 05:18 PST, Patrick R. Gansterer 		webkit.review.bot: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-11-17 05:18:45 PST
Created attachment 115567 [details] Patch
Early Warning System Bot
Comment 2 2011-11-17 05:29:15 PST
Comment on attachment 115567 [details] Patch Attachment 115567 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/10312151
Gyuyoung Kim
Comment 3 2011-11-17 05:55:40 PST
Comment on attachment 115567 [details] Patch Attachment 115567 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/10477165
WebKit Review Bot
Comment 4 2011-11-17 06:17:04 PST
Comment on attachment 115567 [details] Patch Attachment 115567 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/10312158
Note You need to log in before you can comment on or make changes to this bug.