Bug 68033

Summary: Implement globalFlag for WebKitTestRunner
Product: WebKit Reporter: Jon Lee <jonlee>
Component: WebKit2Assignee: Jon Lee <jonlee>
Status: RESOLVED FIXED    
Severity: Enhancement CC: aroben, jonlee, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Mac   
OS: OS X 10.7   
Bug Depends on:    
Bug Blocks: 68091, 28633    
Attachments:
Description Flags
Patch
none
Patch sam: review+

Jon Lee
Reported 2011-09-13 14:55:44 PDT
layoutTestController should have globalFlag like DumpRenderTree
Attachments
Patch (2.41 KB, patch)
2011-09-13 15:50 PDT, Jon Lee 		no flags
DetailsFormatted DiffDiff
Patch (3.19 KB, patch)
2011-09-14 11:01 PDT, Jon Lee 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jon Lee
Comment 1 2011-09-13 15:23:17 PDT
<rdar://problem/10119204>
Jon Lee
Comment 2 2011-09-13 15:50:24 PDT
Created attachment 107247 [details] Patch
Simon Fraser (smfr)
Comment 3 2011-09-13 16:03:53 PDT
What the heck is globalFlag? Can it have a better name?
Jon Lee
Comment 4 2011-09-13 16:05:07 PDT
It's a flag that's globally accessible across all windows. It existed in DRT (grep for globalFlag in the layout tests).
Darin Adler
Comment 5 2011-09-13 16:19:57 PDT
Comment on attachment 107247 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107247&action=review This is OK. But it would be best to also include the patches that can be removed from the Skipped list. > Tools/WebKitTestRunner/InjectedBundle/LayoutTestController.h:205 > + bool m_globalFlag; Need to initialize m_globalFlag in the constructor instead of letting it have a random uninitialized value at first. Also probably need to reset it in between tests.
Jon Lee
Comment 6 2011-09-13 16:32:04 PDT
(In reply to comment #5) > This is OK. But it would be best to also include the patches that can be removed from the Skipped list. I will comb through the list and upload a new patch. > Need to initialize m_globalFlag in the constructor instead of letting it have a random uninitialized value at first. Done > Also probably need to reset it in between tests. If I'm reading the code correctly I believe a new layout test controller is created for each test.
Jon Lee
Comment 7 2011-09-14 11:01:48 PDT
Created attachment 107357 [details] Patch
Jon Lee
Comment 8 2011-09-14 11:05:34 PDT
To expedite the patch, I've decided to instead add a new task to enable the tests that use globalFlag.
Jon Lee
Comment 9 2011-09-14 11:59:57 PDT
Committed r95109: <http://trac.webkit.org/changeset/95109>
Note You need to log in before you can comment on or make changes to this bug.