Bug 67977

Summary:

Implement a PopStateEvent constructor for JSC

Product:

WebKit

Reporter:

Kentaro Hara <haraken>

Component:

DOM

Assignee:

Kentaro Hara <haraken>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, dominicc, haraken, sam, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

67824

Attachments:

Description	Flags
WIP patch	none
WIP patch	none
Patch	none

Kentaro Hara

Reported 2011-09-12 18:41:49 PDT

PopStateEvent should have a constructor (Spec: http://www.whatwg.org/specs/web-apps/current-work/#popstateevent). After this patch is landed, I will add the PopStateEvent constructor for V8 as a follow-up patch.

Attachments
WIP patch (13.31 KB, patch) 2011-09-14 21:27 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
WIP patch (12.67 KB, patch) 2011-09-14 21:56 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
Patch (13.87 KB, patch) 2011-09-15 00:41 PDT, Kentaro Hara	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Kentaro Hara

Comment 1 2011-09-14 21:27:25 PDT

Created attachment 107450 [details] WIP patch

Kentaro Hara

Comment 2 2011-09-14 21:56:09 PDT

Created attachment 107455 [details] WIP patch

Kentaro Hara

Comment 3 2011-09-14 22:08:33 PDT

Question: Which should IDL 'any' be implemented as ScriptValue or SerializedScriptValue? The spec says that the type of both PopStateEvent.state and CustomEvent.detail should be 'any' (http://www.whatwg.org/specs/web-apps/current-work/#popstateevent, http://dvcs.w3.org/hg/domcore/raw-file/tip/Overview.html#interface-customevent). However, in the current WebCore implementation, CustomEvent.state is implemented as ScriptValue (https://bugs.webkit.org/show_bug.cgi?id=67248), and PopStateEvent.detail is implemented as SerializedScriptValue. Which is correct? If we use SerializedScriptValue, some tests violate the spec of IDL 'any' (http://www.w3.org/TR/WebIDL/#es-any), as you can see in the WIP patch. > FAIL new PopStateEvent('eventType', { state: '' }).state should be undefined (of type undefined). Was (of type string). > FAIL new PopStateEvent('eventType', { state: object1 }).state should be [object Object]. Was [object Object]. > FAIL new PopStateEvent('eventType', { state: {valueOf: function () { return object2; } } }).state should be [object Object]. Was [object Object]. > FAIL new PopStateEvent('eventType', { bubbles: true, cancelable: true, state: object3 }).state should be [object Object]. Was [object Object]. In addition, if we use SerializedScriptValue, the test crashes when we pass a DOM object. (I guess we can fix this crash, but we need to throw some exception anyway.) > //shouldBe("new PopStateEvent('eventType', { state: document }).state", "document"); // Crash!!! On the other hand, if we use ScriptValue, we can get correct test results. With these observations, I guess that we should implement PopStateEvent.state as ScriptValue, but are there any problem to change it from SeriazliedScriptValue to ScriptValue?

Kentaro Hara

Comment 4 2011-09-14 22:12:10 PDT

> CustomEvent.state is implemented as ScriptValue (https://bugs.webkit.org/show_bug.cgi?id=67248), and PopStateEvent.detail is implemented as SerializedScriptValue. Correction: CustomEvent.detail is implemented as ScriptValue (https://bugs.webkit.org/show_bug.cgi?id=67248), and PopStateEvent.state is implemented as SerializedScriptValue.

Sam Weinig

Comment 5 2011-09-14 22:33:00 PDT

For now, I would match what the event already has, and file follow up bugs.

Kentaro Hara

Comment 6 2011-09-15 00:41:05 PDT

Created attachment 107472 [details] Patch

Kentaro Hara

Comment 7 2011-09-15 00:42:21 PDT

(In reply to comment #5) > For now, I would match what the event already has, and file follow up bugs. Sam: Thanks. If the patch is OK, I will file the follow-up bugs.

Sam Weinig

Comment 8 2011-09-15 09:42:14 PDT

Comment on attachment 107472 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=107472&action=review > Source/WebCore/dom/PopStateEvent.cpp:36 > +PopStateEventInit::PopStateEventInit() > +{ > + state = SerializedScriptValue::create(); This should probably use initializer syntax.

WebKit Review Bot

Comment 9 2011-09-15 19:45:02 PDT

Comment on attachment 107472 [details] Patch Clearing flags on attachment: 107472 Committed r95262: <http://trac.webkit.org/changeset/95262>

WebKit Review Bot

Comment 10 2011-09-15 19:45:07 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.