Bug 67936

Summary: REGRESSION(r81225): ORWT should ignore reftests
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Balazs Ankes <bank>
Status: RESOLVED FIXED    
Severity: Normal CC: ossy
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 55936    
Attachments:
Description Flags
proposed fix none

Csaba Osztrogonác
Reported 2011-09-12 08:16:45 PDT
When I run ORWT, the following tests are missing from tests_run.txt: (All of them are ref test) editing/pasteboard/data-transfer-items-image-png.html fast/forms/checkbox-appearance-change-by-checked.html fast/forms/file-input-reset.html fast/forms/file/file-reset-in-change.html fast/forms/placeholder-in-invisible-elements.html fast/forms/range/input-appearance-range-rtl.html fast/forms/search-cancel-in-invisible-elements.html fast/harness/font-weight-bold.html fast/harness/sample-fail-mismatch-reftest-expected-mismatch.html fast/harness/sample-mismatch-reftest-expected-mismatch.html fast/harness/sample-mismatch-reftest.html When I passed these tests to the commandline of ORWT, it reported that they are new tests without expected files.
Attachments
proposed fix (1.59 KB, patch)
2012-01-17 06:10 PST, Balazs Ankes 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2012-01-17 03:51:22 PST
If you don't pass any parameter to ORWT or if you pass directory, it ignores reftests, because it can't handle reftests. It's correct behaviour. But if you pass complete test names it reports that they are new tests without expected files. The correct solution can be that ORWT should ignore reftests always.
Balazs Ankes
Comment 2 2012-01-17 06:10:04 PST
Created attachment 122753 [details] proposed fix Based on Csaba Osztrogonac's first comment.
Csaba Osztrogonác
Comment 3 2012-01-17 06:16:26 PST
Comment on attachment 122753 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=122753&action=review LGTM, but the changelog isn't so talkative, please fix it. > Tools/ChangeLog:4 > + [ORWT] Call isUsedInReftest() in findTestsToRun if you pass complete test name. > + https://bugs.webkit.org/show_bug.cgi?id=67936 REGRESSION(r81225): ORWT should ignore reftests https://bugs.webkit.org/show_bug.cgi?id=67936 > Tools/ChangeLog:10 > + (isUsedInReftest): > + (findTestsToRun): (isUsedInReftest): $filename should be the first parameter (findTestsToRun): run test if it isn't reftest
Csaba Osztrogonác
Comment 4 2012-01-17 08:12:11 PST
Fixed patch landed in http://trac.webkit.org/changeset/105162
Note You need to log in before you can comment on or make changes to this bug.