Bug 67889

Summary: [Chromium] The checked state of WebPopupMenuItem isn't initialized
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: fishd, peter, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66687    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-09-10 01:53:28 PDT
[Chromium] The checked state of WebPopupMenuItem isn't initialized
Attachments
Patch (1.74 KB, patch)
2011-09-10 01:54 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-09-10 01:54:53 PDT
Created attachment 106973 [details] Patch
Adam Barth
Comment 2 2011-09-10 01:55:40 PDT
I don't fully understand this patch. If someone else can explain why this diff exists in the Android branch, I'd appreciate that.
Darin Fisher (:fishd, Google)
Comment 3 2011-09-10 17:36:15 PDT
Comment on attachment 106973 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=106973&action=review > Source/WebKit/chromium/ChangeLog:10 > + use popup menus for <select> elements. the mac port uses "external" popup menus for select elements too. this parch seems fine to me, but i'd also like to know the answer to your question. perhaps jcivelli knows?
Peter Beverloo
Comment 4 2011-09-13 06:09:24 PDT
The WebMenuItemInfo struct contained the checked property already, but since it wasn't being set in the ExternalPopupMenu::getPopupMenuInfo method it didn't propagate correctly to Chrome. The information will be used for implementing select boxes which accept multiple answers, for which we'll indeed need an external menu.
Adam Barth
Comment 5 2011-09-13 13:40:55 PDT
Comment on attachment 106973 [details] Patch Ok.
WebKit Review Bot
Comment 6 2011-09-13 14:42:20 PDT
Comment on attachment 106973 [details] Patch Clearing flags on attachment: 106973 Committed r95045: <http://trac.webkit.org/changeset/95045>
WebKit Review Bot
Comment 7 2011-09-13 14:42:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.