Bug 67208

Summary: Get rid of platform specific undefs for NO_ERROR and VERSION in GraphicsContext3D
Product: WebKit Reporter: Chris Marrin <cmarrin>
Component: New BugsAssignee: Chris Marrin <cmarrin>
Status: RESOLVED WONTFIX    
Severity: Normal CC: kbr
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66903    
Attachments:
Description Flags
Patch darin: review-, webkit-ews: commit-queue-

Chris Marrin
Reported 2011-08-30 10:39:08 PDT
Get rid of platform specific undefs for NO_ERROR and VERSION in GraphicsContext3D
Attachments
Patch (10.79 KB, patch)
2011-08-30 10:41 PDT, Chris Marrin 		darin: review-
webkit-ews: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Chris Marrin
Comment 1 2011-08-30 10:41:01 PDT
Created attachment 105649 [details] Patch
Early Warning System Bot
Comment 2 2011-08-30 10:55:36 PDT
Comment on attachment 105649 [details] Patch Attachment 105649 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9572270
Darin Adler
Comment 3 2011-08-30 11:11:27 PDT
Comment on attachment 105649 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105649&action=review This fails to compile. See the Qt EWS build failure. It’s because the IDL and C++ names need to match. To change the names we’d probably need a new feature in the bindings generation script. > Source/WebCore/html/canvas/WebGLRenderingContext.idl:145 > - const unsigned int NO_ERROR = 0; > + const unsigned int NO_ERROR = 0; // This is named GC3D_NO_ERROR in GraphicsContext3D to avoid clash with system defines on some platforms I’m not sure this comment is helpful here. Don’t we have something in the IDL-generation process that requires that the C++ constant and the IDL constant have the same name and same value? I had thought we did, and I’m surprised you are not having problems compiling. > Source/WebCore/html/canvas/WebGLRenderingContext.idl:288 > - const unsigned int VERSION = 0x1F02; > + const unsigned int VERSION = 0x1F02; // This is named GC3D_VERSION in GraphicsContext3D to avoid clash with system defines on some platforms Ditto.
Note You need to log in before you can comment on or make changes to this bug.