Bug 66979

Summary: Remove WKPageCreateSnapshotOfVisibleContent
Product: WebKit Reporter: Jessie Berlin <jberlin>
Component: WebKit2Assignee: Jessie Berlin <jberlin>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, commit-queue, jberlin, sam, webkit.review.bot
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Part 1 (Gut WKPageCreateSnapshotOfVisibleContent)
none
A patch to remove existing the function stub. none

Jessie Berlin
Reported 2011-08-25 14:06:26 PDT
WKPageCreateSnapshotOfVisibleContent makes a sync call from the UI Process to the Web Process. It should be removed as soon as it is possible to do so without breaking the nightlies. <rdar://problem/9314215>
Attachments
Part 1 (Gut WKPageCreateSnapshotOfVisibleContent) (6.85 KB, patch)
2011-08-25 14:43 PDT, Jessie Berlin 		no flags
DetailsFormatted DiffDiff
A patch to remove existing the function stub. (2.25 KB, patch)
2014-10-07 18:17 PDT, Sungmann Cho 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jessie Berlin
Comment 1 2011-08-25 14:08:50 PDT
Part 1 of this should be gutting it - remove the code that actually does the sync call and have it always return 0.
Jessie Berlin
Comment 2 2011-08-25 14:43:29 PDT
Created attachment 105249 [details] Part 1 (Gut WKPageCreateSnapshotOfVisibleContent)
WebKit Review Bot
Comment 3 2011-08-26 09:15:39 PDT
Comment on attachment 105249 [details] Part 1 (Gut WKPageCreateSnapshotOfVisibleContent) Clearing flags on attachment: 105249 Committed r93880: <http://trac.webkit.org/changeset/93880>
WebKit Review Bot
Comment 4 2011-08-26 09:15:43 PDT
All reviewed patches have been landed. Closing bug.
Jessie Berlin
Comment 5 2011-08-26 09:54:50 PDT
Not quite done yet. Still have to remove the function altogether when it won’t break the nighties.
Sungmann Cho
Comment 6 2014-10-07 18:17:54 PDT
Created attachment 239444 [details] A patch to remove existing the function stub.
WebKit Commit Bot
Comment 7 2014-10-07 22:17:32 PDT
Comment on attachment 239444 [details] A patch to remove existing the function stub. Clearing flags on attachment: 239444 Committed r174417: <http://trac.webkit.org/changeset/174417>
WebKit Commit Bot
Comment 8 2014-10-07 22:17:36 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.