Bug 66763

Summary: Remove last occurrences of PLATFORM(ANDROID)
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: mnaganov, peter, satish, steveblock, tonyg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66688    
Attachments:
Description Flags
Patch tonyg: review+

Steve Block
Reported 2011-08-23 04:31:47 PDT
See also Bug 66741
Attachments
Patch (3.27 KB, patch)
2011-08-23 04:36 PDT, Steve Block 		tonyg: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-08-23 04:36:47 PDT
Created attachment 104819 [details] Patch
Tony Gentilcore
Comment 2 2011-08-23 05:22:06 PDT
Comment on attachment 104819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104819&action=review > Source/WebCore/bindings/v8/V8GCController.cpp:-476 > - static const int highUsageDeltaMB = -1; Any background on this? Should it still be present as OS(ANDROID)?
Steve Block
Comment 3 2011-08-23 05:51:16 PDT
Comment on attachment 104819 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104819&action=review >> Source/WebCore/bindings/v8/V8GCController.cpp:-476 >> - static const int highUsageDeltaMB = -1; > > Any background on this? Should it still be present as OS(ANDROID)? I guess we're not sure yet, as I don't know if or how we'll provide this functionality via the Chromium port. In any case, switching it to OS(ANDROID) now will mean that it won't compile, so I thought it best to remove it to allow us to get the Chromium port building for Android ASAP. Peter, do you have any thoughts?
Tony Gentilcore
Comment 4 2011-08-23 05:57:00 PDT
(In reply to comment #3) > (From update of attachment 104819 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=104819&action=review > > >> Source/WebCore/bindings/v8/V8GCController.cpp:-476 > >> - static const int highUsageDeltaMB = -1; > > > > Any background on this? Should it still be present as OS(ANDROID)? > > I guess we're not sure yet, as I don't know if or how we'll provide this functionality via the Chromium port. > > In any case, switching it to OS(ANDROID) now will mean that it won't compile, so I thought it best to remove it to allow us to get the Chromium port building for Android ASAP. Peter, do you have any thoughts? Sounds good.
Peter Beverloo
Comment 5 2011-08-23 06:01:19 PDT
I agree on removing them for now. Re-adding these three variables is trivial and could easily be done as part of supporting the methods in Chromium's PlatformBridge after we decide on how to implement the functionality.
Steve Block
Comment 6 2011-08-23 06:07:40 PDT
Committed r93597: <http://trac.webkit.org/changeset/93597>
Note You need to log in before you can comment on or make changes to this bug.