Bug 66721

Summary: Attempt to clean up bidiNext usage
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, leviw, rniwa, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 50912    
Attachments:
Description Flags
Patch
none
Patch none

Eric Seidel (no email)
Reported 2011-08-22 14:59:07 PDT
Attempt to clean up bidiNext usage
Attachments
Patch (11.28 KB, patch)
2011-08-22 15:04 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Patch (12.36 KB, patch)
2011-08-22 15:17 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-08-22 15:04:06 PDT
Created attachment 104746 [details] Patch
Eric Seidel (no email)
Comment 2 2011-08-22 15:17:43 PDT
Created attachment 104750 [details] Patch
Ryosuke Niwa
Comment 3 2011-08-22 15:28:05 PDT
Comment on attachment 104750 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=104750&action=review r=me. looks sane to me. > Source/WebCore/ChangeLog:24 > + In reviewing this code be aware that the previous bidiNext default was to "skip empty inlines" (skipInlines = true). > + Thus any caller who didn't pass true/false should now be calling bidiNextSkippingEmptyInlines instead. These two lines appear to be much longer than the lines above.
WebKit Review Bot
Comment 4 2011-08-22 16:34:46 PDT
Comment on attachment 104750 [details] Patch Clearing flags on attachment: 104750 Committed r93559: <http://trac.webkit.org/changeset/93559>
WebKit Review Bot
Comment 5 2011-08-22 16:34:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.