Bug 66551

Summary: editing/selection/caret-at-bidi-boundary.html timing out on Windows since it was added
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Ryosuke Niwa <rniwa>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, mrobinson, rniwa, webkit.review.bot
Priority: P2 Keywords: LayoutTestFailure, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows 7   
URL: http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r93369%20(15625)/results.html
Attachments:
Description Flags
fixes the test
none
fixed the tab aroben: review+, aroben: commit-queue+

Adam Roben (:aroben)
Reported 2011-08-19 05:55:44 PDT
editing/selection/caret-at-bidi-boundary.html has been timing out on Windows since it was added in r93369 <http://trac.webkit.org/changeset/93369>. http://build.webkit.org/results/Windows%207%20Release%20(Tests)/r93369%20(15625)/results.html
Attachments
fixes the test (1.38 KB, patch)
2011-08-22 11:38 PDT, Ryosuke Niwa 		no flags
DetailsFormatted DiffDiff
fixed the tab (1.39 KB, patch)
2011-08-22 11:38 PDT, Ryosuke Niwa 		aroben: review+
aroben: commit-queue+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1 2011-08-19 09:50:39 PDT
Also see the bug 66514.
Ryosuke Niwa
Comment 2 2011-08-19 09:52:58 PDT
Does the test still time out if you commented out all but the first dt and dd?
Ryosuke Niwa
Comment 3 2011-08-19 18:40:41 PDT
So the problem is that Windows port's DRT actually sleeps for the amount of time leapForward is called upon :( See replaySavedEvents in win/EventSender.cpp. This is not now other ports implement leapForward.
Ryosuke Niwa
Comment 5 2011-08-19 18:51:14 PDT
Skipped the test in http://trac.webkit.org/changeset/93464.
Martin Robinson
Comment 6 2011-08-21 09:57:27 PDT
(In reply to comment #3) > So the problem is that Windows port's DRT actually sleeps for the amount of time leapForward is called upon :( See replaySavedEvents in win/EventSender.cpp. This is not now other ports implement leapForward. I'm not sure this is accurate. GTK+, Qt and Windows all implement leapForward this way.
Ryosuke Niwa
Comment 7 2011-08-22 11:38:05 PDT
Created attachment 104703 [details] fixes the test
Ryosuke Niwa
Comment 8 2011-08-22 11:38:47 PDT
Created attachment 104704 [details] fixed the tab
WebKit Review Bot
Comment 9 2011-08-22 11:39:54 PDT
Attachment 104703 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/edit..." exit_code: 1 LayoutTests/ChangeLog:8: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Ryosuke Niwa
Comment 10 2011-08-22 11:47:17 PDT
Note I have verified that the test passes on Windows after this change.
Ryosuke Niwa
Comment 11 2011-08-22 12:13:03 PDT
Committed r93529: <http://trac.webkit.org/changeset/93529>
Note You need to log in before you can comment on or make changes to this bug.