Bug 66152

Summary: Use __builtin_trap() for CRASH when building with clang
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 66190    
Attachments:
Description Flags
Patch
none
Patch
none
Patch andersca: review+

Sam Weinig
Reported 2011-08-12 12:13:28 PDT
Use __builtin_trap() for CRASH when building with clang
Attachments
Patch (12.52 KB, patch)
2011-08-12 12:19 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (12.77 KB, patch)
2011-08-12 13:08 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (12.93 KB, patch)
2011-08-12 15:26 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2011-08-12 12:19:11 PDT
Created attachment 103789 [details] Patch
Sam Weinig
Comment 2 2011-08-12 12:19:49 PDT
As a note, I am not happy with the name ASSERT_NO_RETURN. But, while I think of a better name, I want the bots to run on this.
Sam Weinig
Comment 3 2011-08-12 12:20:17 PDT
Second note, this is to make the clang static analyzer be able to reason about ASSERT and CRASH in WebCore!
Early Warning System Bot
Comment 4 2011-08-12 12:32:47 PDT
Comment on attachment 103789 [details] Patch Attachment 103789 [details] did not pass qt-ews (qt): Output: http://queues.webkit.org/results/9351695
Sam Weinig
Comment 5 2011-08-12 13:08:15 PDT
Created attachment 103802 [details] Patch
Sam Weinig
Comment 6 2011-08-12 15:26:31 PDT
Created attachment 103827 [details] Patch
Sam Weinig
Comment 7 2011-08-12 15:27:25 PDT
I have changed the macro to NO_RETURN_DUE_TO_ASSERT (and added NO_RETURN_DUE_TO_CRASH) which I like better as names.
Anders Carlsson
Comment 8 2011-08-12 19:32:20 PDT
Comment on attachment 103827 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=103827&action=review > Source/WebCore/bindings/objc/WebScriptObject.mm:610 > + > +- (void)dealloc NO_RETURN_DUE_TO_ASSERT; > + Please remove the whitespace here.
Sam Weinig
Comment 9 2011-08-12 19:40:57 PDT
Committed r93012: <http://trac.webkit.org/changeset/93012>
Sam Weinig
Comment 10 2011-08-13 10:41:08 PDT
*** Bug 26630 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.