Bug 66004

Summary: Remove ifdefs for CSS exclusions and CSS regions
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: mihnea, peter, rniwa
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 57312    
Attachments:
Description Flags
Patch
aroben: review-
Patch v2 aroben: review+

Dave Hyatt
Reported 2011-08-10 12:39:57 PDT
CSS Exclusions have morphed into a different feature: positioned floats, and I don't want to try to maintain ifdefs in the float code for this, since that will just get pointlessly complicated. Regions also I would like to just turn on, since I expect them to share a bit of code with columns eventually, and I don't want that forked either. The specs are coming along, and I think it's ok to just have this on by default now.
Attachments
Patch (48.35 KB, patch)
2011-08-10 12:43 PDT, Dave Hyatt 		aroben: review-
DetailsFormatted DiffDiff
Patch v2 (59.62 KB, patch)
2011-08-10 13:16 PDT, Dave Hyatt 		aroben: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-08-10 12:43:20 PDT
Created attachment 103519 [details] Patch
Adam Roben (:aroben)
Comment 2 2011-08-10 13:01:36 PDT
Comment on attachment 103519 [details] Patch There are other FeatureDefines.xcconfig files that need to be modified (in places like Source/WebKit2/Configurations, e.g.). And you need to modify WebKitLibraries/win/tools/vsprops/FeatureDefines.*. And maybe other places for other ports, too. And you'll need to modify build-webkit to remove the Regions-related flags, and the files in Tools/BuildSlaveSupport/build.webkit.org-config that control how the CSSRegions bot operates.
Dave Hyatt
Comment 3 2011-08-10 13:16:59 PDT
Created attachment 103525 [details] Patch v2
Adam Roben (:aroben)
Comment 4 2011-08-10 13:20:44 PDT
Comment on attachment 103525 [details] Patch v2 View in context: https://bugs.webkit.org/attachment.cgi?id=103525&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/config.json:259 > - } > + } } Whoops. You also need to delete the declaration of adobe-mac-slave1 higher up in the file.
Dave Hyatt
Comment 5 2011-08-10 13:37:11 PDT
Fixed in r92792.
Ryosuke Niwa
Comment 6 2011-08-10 22:17:40 PDT
This patch deleted the PlatformSpecificSchedule for all SnowLeopard bots :(. Fixed in http://trac.webkit.org/changeset/92820.
Note You need to log in before you can comment on or make changes to this bug.