Bug 65676

Summary: Move <input type=week> tests to fast/forms/week/
Product: WebKit Reporter: Kent Tamura <tkent>
Component: FormsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: hamaji, morrita, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 65915    
Attachments:
Description Flags
Patch tony: review+

Kent Tamura
Reported 2011-08-04 02:54:52 PDT
Move <input type=week> tests to fast/forms/week/ for ease of disabling the week type.
Attachments
Patch (212.14 KB, patch)
2011-08-04 02:57 PDT, Kent Tamura 		tony: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2011-08-04 02:57:46 PDT
Created attachment 102891 [details] Patch
Kent Tamura
Comment 2 2011-08-04 03:01:53 PDT
I'd like to make subdirectories of fast/forms for each of form control types. - ease to disable the type Type=color is disabled temporarily for UI enhancement Use-case of some types are questionable. Such types might be removed from the specification. - discoverability There are a lot of tests in fast/forms/.
Tony Chang
Comment 3 2011-08-04 09:43:01 PDT
Comment on attachment 102891 [details] Patch Looks like we need to move the following results too: chromium-mac/fast/forms/ValidityState-typeMismatch-url-expected.txt chromium-win/fast/forms/ValidityState-typeMismatch-url-expected.txt qt/fast/forms/date-input-visible-strings-expected.png Please watch the bots as you land.
Kent Tamura
Comment 4 2011-08-04 16:15:41 PDT
(In reply to comment #3) Thank you for r+. > Looks like we need to move the following results too: > chromium-mac/fast/forms/ValidityState-typeMismatch-url-expected.txt > chromium-win/fast/forms/ValidityState-typeMismatch-url-expected.txt They are for type=url. So they won't be affected. > qt/fast/forms/date-input-visible-strings-expected.png It's a stale result. date-input-visible-strings.html was changed to dumpAsText() some months ago.
Kent Tamura
Comment 5 2011-08-04 16:17:53 PDT
Committed r92427: <http://trac.webkit.org/changeset/92427>
Tony Chang
Comment 6 2011-08-04 16:19:13 PDT
(In reply to comment #4) > (In reply to comment #3) > > Thank you for r+. > > > Looks like we need to move the following results too: > > chromium-mac/fast/forms/ValidityState-typeMismatch-url-expected.txt > > chromium-win/fast/forms/ValidityState-typeMismatch-url-expected.txt > > They are for type=url. So they won't be affected. > > > qt/fast/forms/date-input-visible-strings-expected.png > > It's a stale result. date-input-visible-strings.html was changed to dumpAsText() some months ago. Ah, you're right, sorry! We should probably just delete qt/fast/forms/date-input-visible-strings-expected.png.
Note You need to log in before you can comment on or make changes to this bug.