Bug 65050

Summary: Replace preprocessor statements in DOMWindow.idl with Conditional attribute
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: Tools / TestsAssignee: Patrick R. Gansterer <paroga>
Status: REOPENED    
Severity: Normal CC: abarth, gustavo.noronha, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 65040, 67427    
Bug Blocks: 67400    
Attachments:
Description Flags
Patch
none
Patch
gustavo.noronha: commit-queue-
Patch
none
Patch gustavo.noronha: commit-queue-

Patrick R. Gansterer
Reported 2011-07-22 15:07:53 PDT
Replace preprocessor statements in DOMWindow.idl with Conditional attribute
Attachments
Patch (35.59 KB, patch)
2011-07-22 15:14 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (35.79 KB, patch)
2011-08-29 13:39 PDT, Patrick R. Gansterer 		gustavo.noronha: commit-queue-
DetailsFormatted DiffDiff
Patch (33.18 KB, patch)
2011-09-01 02:07 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (31.92 KB, patch)
2011-11-12 09:53 PST, Patrick R. Gansterer 		gustavo.noronha: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-07-22 15:14:55 PDT
Created attachment 101775 [details] Patch
Gyuyoung Kim
Comment 2 2011-07-22 15:55:30 PDT
Comment on attachment 101775 [details] Patch Attachment 101775 [details] did not pass efl-ews (efl): Output: http://queues.webkit.org/results/9231225
Gustavo Noronha (kov)
Comment 3 2011-07-22 16:55:08 PDT
Comment on attachment 101775 [details] Patch Attachment 101775 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9233220
Collabora GTK+ EWS bot
Comment 4 2011-07-22 17:02:29 PDT
Comment on attachment 101775 [details] Patch Attachment 101775 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9232170
Brent Fulgham
Comment 5 2011-08-29 12:41:53 PDT
Comment on attachment 101775 [details] Patch Looks good. I like the uniform declarations with this approach; it's much clearer which features are needed for each IDL entry.
Patrick R. Gansterer
Comment 6 2011-08-29 13:39:51 PDT
Created attachment 105517 [details] Patch bug 65050 is closed in the meantime, let's see if EWS is happy now
Collabora GTK+ EWS bot
Comment 7 2011-08-29 16:55:41 PDT
Comment on attachment 105517 [details] Patch Attachment 105517 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/9570080
Patrick R. Gansterer
Comment 8 2011-09-01 02:07:24 PDT
Created attachment 105926 [details] Patch
WebKit Review Bot
Comment 9 2011-09-01 03:23:16 PDT
Comment on attachment 105926 [details] Patch Clearing flags on attachment: 105926 Committed r94284: <http://trac.webkit.org/changeset/94284>
WebKit Review Bot
Comment 10 2011-09-01 03:23:21 PDT
All reviewed patches have been landed. Closing bug.
Nico Weber
Comment 11 2011-09-01 12:10:52 PDT
Comment on attachment 105926 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105926&action=review > Source/WebCore/page/DOMWindow.idl:-625 > -#if defined(ENABLE_SVG) && ENABLE_SVG This breaks building without SVG enabled. Can you revert this part?
Patrick R. Gansterer
Comment 12 2011-09-01 12:50:57 PDT
Reverted r94284 for reason: Broke building without SVG enabled on Chromium. Committed r94334: <http://trac.webkit.org/changeset/94334>
Patrick R. Gansterer
Comment 13 2011-11-12 09:53:43 PST
Created attachment 114838 [details] Patch
Collabora GTK+ EWS bot
Comment 14 2011-11-12 10:04:56 PST
Comment on attachment 114838 [details] Patch Attachment 114838 [details] did not pass gtk-ews (gtk): Output: http://queues.webkit.org/results/10449809
Note You need to log in before you can comment on or make changes to this bug.