Bug 64930

Summary: [Chromium] Port harfbuzz code to new harfbuzz-ng API
Product: WebKit Reporter: Kenichi Ishibashi <bashi>
Component: PlatformAssignee: Kenichi Ishibashi <bashi>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: efidler, evan, jshin, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
URL: http://crbug.com/68551
Attachments:
Description Flags
WIP Patch V0
none
WIP Patch V1 none

Kenichi Ishibashi
Reported 2011-07-21 03:21:56 PDT
This is the WebKit bug entry for http://crbug.com/68551.
Attachments
WIP Patch V0 (53.39 KB, patch)
2011-07-21 04:10 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
WIP Patch V1 (48.03 KB, patch)
2011-07-22 02:14 PDT, Kenichi Ishibashi 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenichi Ishibashi
Comment 1 2011-07-21 04:10:10 PDT
Created attachment 101571 [details] WIP Patch V0
Kenichi Ishibashi
Comment 2 2011-07-21 04:11:41 PDT
(In reply to comment #1) > Created an attachment (id=101571) [details] > WIP Patch V0 Not intended for review, but comments and suggestions are highly appreciated. Some notes for the WIP patch: - Using harfbuzz-ng revision: f6fd3780e12b23ff7ed3743497c8996e71dcb064 - Need to update src/third_party/harfbuzz-ng to the above revision in chromium working copy to compile this patch. - Indic/South East Asian(SEA) scripts are not rendered correctly because harfbuzz-ng doesn't support these script yet. - I don't see performance regression on page cycler test intl1, but selectionRect() remarkably slow than the old harfbuzz. I took a profile and found BEInt::operator<Type>() in hb-open-type-private.hh takes a lot of time. I'd like to ask some advices: - Would it be worth maintain both harfbuzz and harfbuzz-ng for a while, at least harfbuzz-ng can render Indic/SEA script correctly? - If it's worth doing, how should we maintain them? Adding a compile flag, or adding switching mechanism them depends on scripts to be shaped?
Jungshik Shin
Comment 3 2011-07-21 11:18:56 PDT
I'm not sure how to proceed, but what's certain is that we can't switch to hb-ng until Indic and SE Asian scripts are supported by hb-ng.
Kenichi Ishibashi
Comment 4 2011-07-22 02:14:44 PDT
Created attachment 101707 [details] WIP Patch V1
Kenichi Ishibashi
Comment 5 2011-07-22 02:16:43 PDT
(In reply to comment #4) > Created an attachment (id=101707) [details] > WIP Patch V1 Add USE(HARFBUZZ_NG) macro to maintain both old harfbuzz and harfbuzz-ng. Still work in progress.
Kenichi Ishibashi
Comment 6 2012-01-27 01:21:52 PST
*** This bug has been marked as a duplicate of bug 69826 ***
Note You need to log in before you can comment on or make changes to this bug.