Bug 64439

Summary: WIN: NRWT has incorrect fallback for win port
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, aroben, dpranke, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 64486    
Bug Blocks: 38756    
Attachments:
Description Flags
Patch none

Eric Seidel (no email)
Reported 2011-07-13 02:13:25 PDT
new-run-webkit-tests has incorrect fallback for win port
Attachments
Patch (49.53 KB, patch)
2011-07-13 03:32 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2011-07-13 03:32:49 PDT
Created attachment 100650 [details] Patch
Eric Seidel (no email)
Comment 2 2011-07-13 03:33:04 PDT
Comment on attachment 100650 [details] Patch This is really a wip patch.
WebKit Review Bot
Comment 3 2011-07-13 03:35:03 PDT
Attachment 100650 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Tools/ChangeLog', u'Tools/Scripts/webkitpy..." exit_code: 1 Tools/Scripts/webkitpy/layout_tests/port/base.py:560: at least two spaces before inline comment [pep8/E261] [5] Total errors found: 1 in 18 files If any of these errors are false positives, please file a bug against check-webkit-style.
Eric Seidel (no email)
Comment 4 2011-07-13 11:21:32 PDT
*** Bug 64469 has been marked as a duplicate of this bug. ***
Adam Roben (:aroben)
Comment 5 2011-07-13 11:29:27 PDT
Comment on attachment 100650 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=100650&action=review > Tools/Scripts/webkitpy/layout_tests/port/win.py:58 > + if not hasattr(sys, 'getwindowsversion'): Cygwin's Python doesn't have sys.getwindowsversion(), so this won't work as-is for Apple's Windows port.
Eric Seidel (no email)
Comment 6 2011-07-13 14:00:05 PDT
I guess we'll have to make our own wrapper around GetVersionEx then?
Eric Seidel (no email)
Comment 7 2011-07-13 14:00:49 PDT
We should be able to build such with ctypes: http://docs.python.org/library/ctypes.html But I think that may be beyond my ability without having a windows machine easily accessible.
Adam Roben (:aroben)
Comment 8 2011-07-13 14:10:16 PDT
(In reply to comment #6) > I guess we'll have to make our own wrapper around GetVersionEx then? Or we could run `cmd /c ver`, like ORWT does.
Eric Seidel (no email)
Comment 9 2011-08-09 15:16:26 PDT
I think this just ended up a duplicate of bug 64486
Eric Seidel (no email)
Comment 10 2011-08-09 15:19:17 PDT
Much of the factory stuff and SUPPORTED_OS_VERSIONS code has been replaced by the new TestConfiguration stuff. I think we can close this as fixed or duplicate.
Note You need to log in before you can comment on or make changes to this bug.