Bug 63865

Summary: SVGAnimatedPath needs fallback for 'by' animation
Product: WebKit Reporter: Dirk Schulze <krit>
Component: SVGAssignee: Dirk Schulze <krit>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot, zimmermann
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 41761    
Attachments:
Description Flags
Patch rwlbuis: review+

Dirk Schulze
Reported 2011-07-02 13:38:26 PDT
SVGAnimatedPath needs fallback for 'by' animation.
Attachments
Patch (20.30 KB, patch)
2011-07-02 13:52 PDT, Dirk Schulze 		rwlbuis: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dirk Schulze
Comment 1 2011-07-02 13:52:30 PDT
Created attachment 99559 [details] Patch
WebKit Review Bot
Comment 2 2011-07-02 13:54:53 PDT
Attachment 99559 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/svg/..." exit_code: 1 Source/WebCore/svg/SVGAnimatedPath.cpp:72: The parameter type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5] Source/WebCore/svg/SVGAnimatedPath.cpp:72: The parameter type should use PassOwnPtr instead of OwnPtr. [readability/pass_ptr] [5] Total errors found: 2 in 7 files If any of these errors are false positives, please file a bug against check-webkit-style.
Rob Buis
Comment 3 2011-07-07 10:15:57 PDT
Comment on attachment 99559 [details] Patch LGTM
Dirk Schulze
Comment 4 2011-07-07 11:44:05 PDT
Committed r90582: <http://trac.webkit.org/changeset/90582>
Note You need to log in before you can comment on or make changes to this bug.