Bug 63720

Summary: [GTK] Add DeviceOrientation feature
Product: WebKit Reporter: Joone Hur <joone.hur>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: gustavo, mrobinson, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 52206    
Attachments:
Description Flags
Proposed Patch
none
Proposed Patch2
mrobinson: review+
Proposed Patch3 none

Joone Hur
Reported 2011-06-30 08:18:02 PDT
We can enable DeviceOrientaion feature for mobile devices.
Attachments
Proposed Patch (15.12 KB, patch)
2011-06-30 18:15 PDT, Joone Hur 		no flags
DetailsFormatted DiffDiff
Proposed Patch2 (15.27 KB, patch)
2011-07-01 00:36 PDT, Joone Hur 		mrobinson: review+
DetailsFormatted DiffDiff
Proposed Patch3 (15.28 KB, patch)
2011-07-01 09:05 PDT, Joone Hur 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Joone Hur
Comment 1 2011-06-30 18:15:46 PDT
Created attachment 99410 [details] Proposed Patch Add configure option to enable/disable DeviceOrientation feature. Add empty implementation of DeviceMotionClient and DeviceOrientationClient callback methods.
Martin Robinson
Comment 2 2011-06-30 18:20:58 PDT
Comment on attachment 99410 [details] Proposed Patch View in context: https://bugs.webkit.org/attachment.cgi?id=99410&action=review > Source/WebKit/gtk/WebCoreSupport/DeviceMotionClientGtk.cpp:29 > +namespace WebCore { Why not namespace WebKit? > Source/WebKit/gtk/WebCoreSupport/DeviceOrientationClientGtk.cpp:29 > +namespace WebCore { Why not namespace WebKit?
Joone Hur
Comment 3 2011-07-01 00:36:13 PDT
Created attachment 99436 [details] Proposed Patch2 The QT and Efl port define the WebCore namespace in the source files from the WebCoreSupport directory, but I didn't notice that the GTK+ port defines the WebKit namespace. Anyway, I also think defining the WebKit namespace seems natural because those files are under Source/WebKit directory. Thanks for the review!
Martin Robinson
Comment 4 2011-07-01 07:25:09 PDT
Comment on attachment 99436 [details] Proposed Patch2 View in context: https://bugs.webkit.org/attachment.cgi?id=99436&action=review > configure.ac:935 > + [enable support for DeviceOrientation (experimental) [default=no]]), Do you mind saying something like "experimental and incomplete" here?
Joone Hur
Comment 5 2011-07-01 09:05:16 PDT
Created attachment 99478 [details] Proposed Patch3 Okay, I've added "incomplete" to the help string.
WebKit Review Bot
Comment 6 2011-07-01 09:56:33 PDT
Comment on attachment 99478 [details] Proposed Patch3 Clearing flags on attachment: 99478 Committed r90240: <http://trac.webkit.org/changeset/90240>
WebKit Review Bot
Comment 7 2011-07-01 09:56:38 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.