Bug 63472

Summary: [Qt] Change default backend to use GStreamer on Linux and QuickTime on Mac.
Product: WebKit Reporter: Alexis Menard (darktears) <menard>
Component: WebKit QtAssignee: Alexis Menard (darktears) <menard>
Status: RESOLVED FIXED    
Severity: Normal CC: abecsi, ademar, admin, admin, admin, alexvolcan, ap, david, dgme.life, laszlo.gombos, michael, myballancenow, mykohlscardguide, mykplan.life, nancy.piedra, navarra, njmcdirecttonline, ramirez, reply, reply, reply, reply, reply, reply, reply, reply, scott, tabotapife, tenmile, william, yael
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 58548, 65369    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch kling: review+, ossy: commit-queue-

Alexis Menard (darktears)
Reported 2011-06-27 12:27:09 PDT
As discussed on the mailing list https://lists.webkit.org/pipermail/webkit-qt/2011-June/001633.html, it is better for the Qt port to move away from Qt Multimedia as the default backends on Linux and Mac. We can rely on QuickTime and GStreamer backends inside WebKit as they are more easy to change, more reliable to use and we share the maintenance with the WebKit community. USE_QTMULTIMEDIA=1 is now the option to force the usage of Qt Multimedia. I'll commit later this patch when we have a public build bot on Mac and the 58548 will be fixed.
Attachments
Patch (7.93 KB, patch)
2011-06-27 12:47 PDT, Alexis Menard (darktears) 		no flags
DetailsFormatted DiffDiff
Patch (7.60 KB, patch)
2011-07-25 12:04 PDT, Alexis Menard (darktears) 		kling: review+
ossy: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexis Menard (darktears)
Comment 1 2011-06-27 12:47:06 PDT
Created attachment 98768 [details] Patch
Laszlo Gombos
Comment 2 2011-06-27 14:21:44 PDT
Comment on attachment 98768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98768&action=review > Source/WebCore/WebCore.pri:-257 > - DEFINES += WTF_USE_QTKIT=1 I do not see where QuickTime backend is set as a default media player. Where is WTF_USE_QTKIT set to 1 ? > Source/WebCore/WebCore.pri:-266 > - DEFINES += WTF_USE_GSTREAMER=1 Same as above; where is WTF_USE_GSTREAMER set to 1 ?
Alexis Menard (darktears)
Comment 3 2011-06-27 14:34:05 PDT
Comment on attachment 98768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98768&action=review >> Source/WebCore/WebCore.pri:-257 >> - DEFINES += WTF_USE_QTKIT=1 > > I do not see where QuickTime backend is set as a default media player. Where is WTF_USE_QTKIT set to 1 ? feature.pri which is include everywhere first. >> Source/WebCore/WebCore.pri:-266 >> - DEFINES += WTF_USE_GSTREAMER=1 > > Same as above; where is WTF_USE_GSTREAMER set to 1 ? Ditto.
Laszlo Gombos
Comment 4 2011-06-28 21:42:54 PDT
Comment on attachment 98768 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=98768&action=review Overall the direction looks good to me. > Source/WebCore/features.pri:213 > DEFINES -= ENABLE_VIDEO=0 > DEFINES += ENABLE_VIDEO=1 > DEFINES -= WTF_USE_QT_MULTIMEDIA=0 > DEFINES += WTF_USE_QT_MULTIMEDIA=1 > + DEFINES -= WTF_USE_QTKIT=1 > + DEFINES += WTF_USE_QTKIT=0 > + DEFINES -= WTF_USE_GSTREAMER=1 > + DEFINES += WTF_USE_GSTREAMER=0 Are the "DEFINES += XXX=0" statements are really necessary? It seems that the corresponding tests are all testing for "contains(DEFINES, XXX=1)" I also find it hard to maintain and read. Would the following work instead ? # HTML5 Media Support !contains(DEFINES, ENABLE_VIDEO=.) { linux-*|mac|contains(MOBILITY_CONFIG, multimedia) { DEFINES += ENABLE_VIDEO=1 mac:!contains(DEFINES, USE_QTMULTIMEDIA=1) { DEFINES += WTF_USE_QTKIT=1 } else: linux-*:!contains(DEFINES, USE_QTMULTIMEDIA=1) { DEFINES += WTF_USE_GSTREAMER=1 } else: contains(MOBILITY_CONFIG, multimedia) { DEFINES += WTF_USE_QT_MULTIMEDIA=1 } } }
Yael
Comment 5 2011-07-07 14:48:38 PDT
Comment on attachment 98768 [details] Patch Since you are turning video on by default now, you should update http://trac.webkit.org/wiki/BuildingQtOnLinux with the new build dependencies.
Alexis Menard (darktears)
Comment 6 2011-07-25 12:04:28 PDT
Created attachment 101890 [details] Patch
Csaba Osztrogonác
Comment 7 2011-07-26 05:37:00 PDT
Comment on attachment 101890 [details] Patch r- because it broke incremental build. And it killed the Qt EWS too. Check https://bugs.webkit.org/show_bug.cgi?id=38054 for details.
Andreas Kling
Comment 8 2011-07-26 06:20:09 PDT
Comment on attachment 101890 [details] Patch r=me, but you need to find a way to land this without making our bot masters cry.
Andras Becsi
Comment 9 2011-07-26 06:34:53 PDT
Committed r91752: <http://trac.webkit.org/changeset/91752>
Ademar Reis
Comment 10 2011-07-29 08:41:36 PDT
Revision r91752 cherry-picked into qtwebkit-2.2 with commit 7a53b15 <http://gitorious.org/webkit/qtwebkit/commit/7a53b15>
Note You need to log in before you can comment on or make changes to this bug.