Bug 63237

Summary: [Qt] Fix tst_QWebFrame::setUrlWithPendingLoads() API test
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: WebKit QtAssignee: Csaba Osztrogonác <ossy>
Status: RESOLVED FIXED    
Severity: Normal CC: aparna.nand, hausmann, jturcotte, ossy
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 38654    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2011-06-23 01:56:27 PDT
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/34519 FAIL! : tst_QWebFrame::setUrlWithPendingLoads() Received a fatal error. Loc: [Unknown file(0)]
Attachments
Patch (1.90 KB, patch)
2012-11-14 04:42 PST, Csaba Osztrogonác 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1 2011-06-23 05:51:50 PDT
Marked as expected fails: http://trac.webkit.org/changeset/89561
Aparna Nandyal
Comment 2 2011-07-21 11:42:12 PDT
Cause for this failure: 1. setHtml is done first and this makes request to cache loader to load the image. This in turn makes an asynchronous request and even before the asynchronous call is completed setUrl is called. 2. setUrl does not cancel the previous request before loading the new url. Hence the problem. Would it be acceptable to cancel the request before actually going on to clear the frame like: void QWebFrame::setUrl(const QUrl &url) { d->frame->loader()->stopForUserCancel(); clearCoreFrame(d->frame); ... } Alternately the test case would pass if we add waitForSignal between the setHtml and setUrl calls.
Csaba Osztrogonác
Comment 3 2012-11-14 04:42:22 PST
Created attachment 174131 [details] Patch
Csaba Osztrogonác
Comment 4 2012-11-14 05:29:50 PST
Comment on attachment 174131 [details] Patch Clearing flags on attachment: 174131 Committed r134596: <http://trac.webkit.org/changeset/134596>
Csaba Osztrogonác
Comment 5 2012-11-14 05:29:56 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.