Bug 63132

Summary: [Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
Product: WebKit Reporter: Csaba Osztrogonác <ossy>
Component: Tools / TestsAssignee: Zeno Albisser <zeno>
Status: RESOLVED FIXED    
Severity: Critical CC: cmarcelo, dihan.wickremasuriya, laszlo.gombos, mdelaney7, ossy, webkit.review.bot, zeno
Priority: P1 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.6   
Bug Depends on:    
Bug Blocks: 63093, 79666, 79668    
Attachments:
Description Flags
Patch none

Csaba Osztrogonác
Reported 2011-06-22 04:55:12 PDT
I don't have a Mac, so I can't test it. I cc-ed Qt Mac responsibles. Wed Jun 22 07:33:01 .... DumpRenderTree[1302] <Error>: ATSFontGetFileReference failed: error -50. Segmentation fault
Attachments
Patch (1.48 KB, patch)
2012-05-16 11:05 PDT, Marcelo Lira 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Matthew Delaney
Comment 1 2011-06-22 08:10:47 PDT
I believe I saw this failing when I ran the layout tests before I made my code change. I'll try to track down the revision when I get in.
Matthew Delaney
Comment 2 2011-06-22 08:14:34 PDT
Actually, I take that back. There was another fast/css font test that had been failing on my mac. Did you see this failing on the Qt Mac bots? They look green at the moment - did someone check in expected failing results?
Csaba Osztrogonác
Comment 3 2011-06-22 10:35:01 PDT
Qt Mac bot isn't core builder, you can find it here: http://build.webkit.sed.hu/waterfall - Qt SnowLeopard Intel Release fast/css/custom-font-xheight.html still crashes on it
Csaba Osztrogonác
Comment 4 2011-06-27 01:39:56 PDT
It seems QtWebKit can live with this crash, but red buildbot is absolutely useless, so I added this test to the Skipped list: http://trac.webkit.org/changeset/89807
Marcelo Lira
Comment 5 2012-05-16 11:05:51 PDT
Created attachment 142302 [details] Patch
Alexis Menard (darktears)
Comment 6 2012-05-16 11:15:22 PDT
Comment on attachment 142302 [details] Patch rs=me please watch the http://build.webkit.sed.hu/builders/Qt%20Lion%20Intel%20Release to make sure it doesn't crash there.
WebKit Review Bot
Comment 7 2012-05-16 12:47:26 PDT
Comment on attachment 142302 [details] Patch Clearing flags on attachment: 142302 Committed r117325: <http://trac.webkit.org/changeset/117325>
WebKit Review Bot
Comment 8 2012-05-16 12:47:32 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.