Bug 62798

Summary: MediaStream API: Runtime enabled features
Product: WebKit Reporter: Tommy Widenflycht <tommyw>
Component: DOMAssignee: Tommy Widenflycht <tommyw>
Status: RESOLVED FIXED    
Severity: Normal CC: leandrogracia, tonyg, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 56459    
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tommy Widenflycht
Reported 2011-06-16 08:08:12 PDT
Add the WebRuntimeFeatures API and enable the feature by default in DumpRenderTree.
Attachments
Patch (3.46 KB, patch)
2011-06-16 08:13 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (3.41 KB, patch)
2011-06-16 08:22 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Patch (3.63 KB, patch)
2011-06-16 08:26 PDT, Tommy Widenflycht 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Tommy Widenflycht
Comment 1 2011-06-16 08:13:12 PDT
Created attachment 97443 [details] Patch
Tony Gentilcore
Comment 2 2011-06-16 08:17:21 PDT
Comment on attachment 97443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97443&action=review Just fix up the changelog and i'll cq+ this. > Source/WebKit/chromium/ChangeLog:5 > + WebRuntimeFeatures Stray diff? Extra ChangeLog information should go below the title and bug link. Also, you should add at least a sentence about what this patch does.
Tommy Widenflycht
Comment 3 2011-06-16 08:22:02 PDT
Created attachment 97445 [details] Patch
Tommy Widenflycht
Comment 4 2011-06-16 08:23:48 PDT
Comment on attachment 97443 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=97443&action=review >> Source/WebKit/chromium/ChangeLog:5 >> + WebRuntimeFeatures > > Stray diff? Extra ChangeLog information should go below the title and bug link. > > Also, you should add at least a sentence about what this patch does. Sorry about that, will fix properly this time.
Tommy Widenflycht
Comment 5 2011-06-16 08:26:39 PDT
Created attachment 97447 [details] Patch
Leandro Graciá Gil
Comment 6 2011-06-16 08:29:24 PDT
If you've checked it works this looks good to me.
WebKit Review Bot
Comment 7 2011-06-16 09:20:05 PDT
Comment on attachment 97447 [details] Patch Clearing flags on attachment: 97447 Committed r89032: <http://trac.webkit.org/changeset/89032>
WebKit Review Bot
Comment 8 2011-06-16 09:20:09 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.