Bug 62756

Summary: Clarify FileChooser creation code.
Product: WebKit Reporter: Dimitri Glazkov (Google) <dglazkov>
Component: New BugsAssignee: Dimitri Glazkov (Google) <dglazkov>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 62069    
Attachments:
Description Flags
Patch none

Dimitri Glazkov (Google)
Reported 2011-06-15 14:28:49 PDT
Clarify FileChooser creation code.
Attachments
Patch (2.27 KB, patch)
2011-06-15 14:31 PDT, Dimitri Glazkov (Google) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Dimitri Glazkov (Google)
Comment 1 2011-06-15 14:31:20 PDT
Created attachment 97364 [details] Patch
Adam Barth
Comment 2 2011-06-15 14:32:06 PDT
Comment on attachment 97364 [details] Patch Even I can see that this change is correct.
WebKit Review Bot
Comment 3 2011-06-15 15:12:04 PDT
Comment on attachment 97364 [details] Patch Clearing flags on attachment: 97364 Committed r88977: <http://trac.webkit.org/changeset/88977>
WebKit Review Bot
Comment 4 2011-06-15 15:12:08 PDT
All reviewed patches have been landed. Closing bug.
Alexey Proskuryakov
Comment 5 2011-06-15 17:45:57 PDT
Comment on attachment 97364 [details] Patch Why not fold it into the constructor? We don't usually do anything besides new+adopt in create() functions.
Dimitri Glazkov (Google)
Comment 6 2011-06-15 17:55:07 PDT
(In reply to comment #5) > (From update of attachment 97364 [details]) > Why not fold it into the constructor? We don't usually do anything besides new+adopt in create() functions. loadIcon refs FileChooser and that can be a bad, bad thing. We even ASSERT about it in RefCounted.
Note You need to log in before you can comment on or make changes to this bug.